Configure excludes polish

[isidorn]

Related to #4007

Steps to Reproduce:

1. Have a large workspace, generate a jsconfig.json that does not exclude anything, click on Configure Excludes in the status bar
2. You get the attached message
3. I propose the following changes:

• Rename "Configure excludes..." action to "Configure Excludes"
• In this particular case the suggestion is not very precise, why are we tryign to be smart here, the user should decide what to exclude himself imho
• The title of the project seems to be wrong - why not use the same we show in the explorer header, in this case 'vscode'

[egamma]

👍
While the algorithm to find large folders is nice. A user that configures the excludes knows where the generated js resources are. Therefore do not add the guessed folders to the message.

[jrieken]

I disagree, folks won't know to exclude things like temp folders which become giant because of a transient build step. node_modules et al are the obvious but we have been hurt more than once with those unusual folders

[jrieken]

Rename "Configure excludes..." action to "Configure Excludes"

I put the ... because it opens a new UI element which I believe is the rule?

In this particular case the suggestion is not very precise, why are we tryign to be smart here, the user should decide what to exclude himself imho

see above

The title of the project seems to be wrong - why not use the same we show in the explorer header, in this case 'vscode'

Agree, it's the filename of the configuration but the action already takes you there...

[isidorn]

I put the ... because it opens a new UI element which I believe is the rule?

Not sure where else in UI we use this rule? AFAIK we do not follow it in debug and task world
@stevencl opinions?

[jrieken]

Like here for instance. Unsure if it's applies to message-actions?

[isidorn]

Yeah i was thinking more of action labels

[jrieken]

removed in the ... with #4248

[egamma]

I disagree, folks won't know to exclude things like temp folders which become giant because of a transient build step. node_modules et al are the obvious but we have been hurt more than once with those unusual folders

Good point but then let's use heuristics and not show just all folders including many files. Only mention the suspects 'temp' and 'tmp' if they are big.

[jrieken]

I'd approach it the other way around and not show folders like src or test and if that results to a case in which I have no folder left to propose exclusion for a generic message will show.

And on the other hand tsserver will generate a similar message which blames the last folder (https://github.com/Microsoft/TypeScript/blob/release-1.8/src/compiler/program.ts#L1117)

[egamma]

Excluding well known source folders like src and test works for me.

[jrieken]

excluding src, test, and tests now

[isidorn]

Nice!