Ability to contribute views containers #43645

sandy081 · 2018-02-14T10:08:02Z

Ability to contribute views containers to the Activity bar like azure, outline etc.,
Contribute views to these activity groups

The text was updated successfully, but these errors were encountered:

sandy081 · 2018-03-19T14:26:36Z

An UX discussion happened and the following solution was suggested in two steps

Step 1

Provide an extension point to contribute activity bar group (viewlet) and allow extensions to group views.
If there are multiple contributions with the same group id, last one wins

Advantages:

Extension can group the views they would like to have under single viewlet. This will work well with azure views.

Disadvantages:

Each Extension can create its own viewlet and there could be too many icons in the activity bar. This is mitigated by our activity bar that can scale.
User has no control to group or ungroup views. If two extensions contribute git related views under two different viewlets, then user cannot group them into one. If an extension contribute azure and docker views under single viewlet and then it is not possible for user to make docker as a separate viewlet.

Step 2

Ability to move views across groups . This is a big discussion scopes to complete VS Code.

Moving across groups / panels etc.

Follow up tasks:

Start with Step 1: Create UI mock ups for contributing viewlets and get feedback from team and community

I would defer this to next milestone due to me being not available completely in this milestone.

eamodio · 2018-03-19T16:28:44Z

@sandy081 how would the (default) order of views contributed into an activity be defined? Would it just be order of registration?

eamodio · 2018-03-19T16:31:00Z

I would love to see the possible future ability of putting a WebView into an activity as this UI/UX/API evolves as well.

sandy081 · 2018-03-19T17:06:13Z

how would the (default) order of views contributed into an activity be defined? Would it just be order of registration?

@eamodio Yes, it would be based on the order of registration.

ghost · 2018-03-20T09:42:05Z

I'd like to suggest the ability to modify the custom activity's icon through icon packs/themes!

rozzzly · 2018-03-24T04:51:11Z

I'd like to see the ability to contribute views/allow users to "dock" views on the opposite side of the activity bar and in the bottom (terminal/problems/etc) bar.

I know the vs code team is reticent about allowing custom UIs so the editor can stay "light and simple" but with custom TreeView and now the new WebView coming as well, that is what will eventually happen.

Ascii Example

----------------------------------------------------
| A |           |                        |         |
| C |           |                        |         |
| T |           |                        |         |
| V |           |          Code          |  Code   |
| I | File Tree |         Editor         | Outline |
| T |           |                        |         |
| Y |           |                        |         |
|   |           |----------------------------------|
| B |           | Problems / Terminal / [Coverage] |
| A |           |                                  |
| R |           |     [ Custom Coverage View ]     |
|   |           |                                  |
----------------------------------------------------

in this example, I could have an extension that contributes some type of "code outline" TreeView on the right, and another extension that contributes a WebView with coverage reports in the bottom bar.

Now I know some core contributors are dead set against this type of thing, but this is where the UI is heading with the introduction of custom views, now you're talking about custom view positioning...

As far as I see it, the vscode team can follow one of two paths:

Custom Views ▶️ Custom View Group ▶️ Custom Activities ▶️ 🕥 API stabilizes ▶️ Extension Authors implement custom views ▶️ users love them but are frustrated because they have to jam all of their tools into one part of the screen ▶️ 📢 users complain, alot ▶️ vscode team eventually relents ▶️ a bunch of code goes into the 🗑 and is rewritten ▶️ 🕥 API stabilizes ▶️ community is happy

OR

Custom Views ▶️ new view contribution/docking API ▶️ 🕥 API stabilizes ▶️ community is happy

DanTup · 2018-03-26T11:39:16Z

I'd love to see this - it feels wonky that we're putting some trees in the File Explorer pane. I'd also love for the user to be able to dock it to the other side too (this goes for existing panels too; a generic solution that lets my undock Git or search results for example).

eamodio · 2018-04-03T14:05:29Z

It would be great to have the ability for badges on the custom activities as well. Just like the change count on the SCM activity.

sandy081 · 2018-04-17T07:25:17Z

Following is the contribution point I am planning to expose

"contributes": {
	"viewsContainers": {
		"activitybar": [
                        {
			    "id": "azure",
			    "title": "Azure",
			     "icon": "resources/azure.png"
		        }
                  ]
	},
        "views": {
		"azure": [
			{
				"id": "cosmosdb",
				"name": "Azure Cosmos DB"
			},
                         {
				"id": "docker",
				"name": "Docker"
			}
		]
	}
}

Register an activity group
Contribute views to the registered activity group location
An extension can also contribute to an activity group registered by a different extension by adding it as a dependency
If the location is not found, view is added to explorer as a fallback.

@jrieken for API discussion

Want to have the new contribution behind the flag (like proposed).

@chrisdias FYI

eamodio · 2018-04-25T16:24:38Z

@sandy081 it seems that today's insiders has broken this -- The activity shows up, but the view never renders. Its getTreeItem and getChildren never get called.

d-akara · 2018-04-25T17:03:50Z

@sandy081 Ahh ok awesome! sorry, I didn't quite get what meant initially.

sandy081 · 2018-04-25T17:06:27Z

@eamodio Yeah, I fixed it today. Sorry for that.

sandy081 · 2018-04-25T17:09:18Z

Pushed a change to provide out of the box Test view container. All extensions contributing test views can contribute to this container using the id test.

eamodio · 2018-04-25T17:11:58Z

@sandy081 ah, great that its fixed -- thanks! (I'm assuming there won't be a new release issued until tomorrow right?)

sandy081 · 2018-04-25T17:16:22Z

@eamodio Unfortunately yes. Please let me know if you are blocked, I can request a new build for you.

eamodio · 2018-04-25T17:19:45Z

If it isn't too much trouble that would be very helpful and greatly appreciated.

sandy081 · 2018-04-25T17:28:55Z

How about sharing a latest build to you instead of releasing it? Does it works?

eamodio · 2018-04-25T17:48:09Z

Sure, works for me, thanks!

DanTup · 2018-04-26T10:14:43Z

Pushed a change to provide out of the box Test view container. All extensions contributing test views can contribute to this container using the id test.

Neat! :)

@sandy081

You can also consider removing Flutter from your view name as you are putting your view into Flutter container. Then it looks like Flutter: Outline which is pretty good.

Good idea! I think ultimately this might just become an "outline", since we'll have a standard non-flutter outline, but for now I think this works fine 👍

sandy081 · 2018-04-26T10:30:45Z

Removed the proposed api flag and this will be available in next stable release.

DanTup · 2018-04-26T10:34:50Z

@sandy081 Two minor things I noticed while working on my outline:

If I call reveal, the sidebar switches to my view. This could be annoying to the user - I want to keep the item in the tree that corresponds to where the cursor is selected, but I don't want to force the tree to be visible it it's not already. Is there a way I can set the selection (so that if they switch to this bar, it's selected) without forcing the view to become visible?
(This is kinda tree-reveal-related rather than this one, but...) if I call reveal(null) it doesn't remove the current selection. So if the user moves the cursor to a position that is not represented by a node (eg. the space between two classes) the previous node remains selected. Any way to remove a selection?

sandy081 · 2018-04-26T12:07:16Z

Here is the request for 1) - #48198

Please file a separate request for 2).

Thanks.

DanTup · 2018-04-26T12:29:55Z

Thanks; opened #48754 :)

patrys · 2018-04-26T13:46:56Z

@DanTup Are you also working on a code outline extension? Maybe we could get a standard view container for our extensions like there is one for tests? (I am the author of Code Outline.)

DanTup · 2018-04-26T14:01:18Z

@patrys I'm not working on an Outline extension, I author the Dart/Flutter extensions. I'm currently working on a special type of outline for Flutter (which will need to be rendered by us, it's very specific), though we do have a standard outline in our backlog.

For the Flutter one, I think a Flutter icon on the side bar makes sense (there are other tools we may add to it in future), but the standard outline may make sense to share a view. However, it raises some questions:

If two extensions contribute view containers with the same ID and different titles, which gets displayed?
If an extension provides its own outline and an "Outline extension" also provides an outline, is there user going to end up with two outlines?

sandy081 · 2018-04-26T14:04:09Z

If two extensions contribute view containers with the same ID and different titles, which gets displayed?

Edit: The first one wins

If an extension provides its own outline and an "Outline extension" also provides an outline, is there user going to end up with two outlines?

Yes

sandy081 · 2018-04-27T07:33:04Z

Closing this issue.. Please file separate issues for new feature requests or bugs

sandy081 self-assigned this Feb 14, 2018

sandy081 added feature-request Request for new features or functionality api tree-views Extension tree view issues labels Feb 14, 2018

sandy081 added this to the February 2018 milestone Feb 14, 2018

kieferrm mentioned this issue Feb 14, 2018

Iteration Plan for February 2018 #43361

Closed

45 tasks

egamma mentioned this issue Feb 16, 2018

Adding to the activity bar from extensions #33609

Closed

sandy081 mentioned this issue Feb 19, 2018

Support custom views in other locations #28662

Closed

1 task

mrpotatoes mentioned this issue Feb 25, 2018

Add some API to support GUI customization #1833

Open

sandy081 modified the milestones: February 2018, March 2018 Feb 26, 2018

kieferrm mentioned this issue Mar 16, 2018

Iteration Plan for March 2018 #45632

Closed

70 tasks

sandy081 modified the milestones: March 2018, April 2018 Mar 19, 2018

rmunn mentioned this issue Mar 26, 2018

Test Runner Viewlet with an Extension API to plug into [Enhancement Request] #9505

Closed

kieferrm mentioned this issue Apr 7, 2018

Iteration Plan for April 2018 #47369

Closed

45 tasks

sandy081 changed the title ~~Ability to promote custom views to activity bar~~ Ability to contribute activity bar groups Apr 16, 2018

sandy081 added a commit that referenced this issue Apr 16, 2018

#43645 Prepare for activity groups contribution

20acc5e

sandy081 added a commit that referenced this issue Apr 16, 2018

#43645 Remove unused imports

39b52b9

sandy081 added a commit that referenced this issue Apr 16, 2018

#43645 Create contribution point activityBarGroups

66706a9

sandy081 added a commit that referenced this issue Apr 16, 2018

#43645 Remove unused imports

ab7fe23

sandy081 added a commit that referenced this issue Apr 25, 2018

#43645 Out of the box test view container

7973d15

sandy081 added a commit that referenced this issue Apr 25, 2018

#43645 Update views schema to show 'test' location

d176b34

sandy081 added a commit that referenced this issue Apr 26, 2018

#43645 Lift off proposed api flag

b1f5a4d

sandy081 added a commit that referenced this issue Apr 26, 2018

#43645 Do not override view containers

ded0736

sandy081 closed this as completed Apr 27, 2018

fiveisprime mentioned this issue Apr 30, 2018

Use views container to add Azure section in activity bar microsoft/vscode-azuretools#167

Closed

mjbvz mentioned this issue May 1, 2018

Allow extensions to add additional views #710

Closed

alefragnani mentioned this issue May 2, 2018

Move the TreeView to use the new "Activity Bar" API alefragnani/vscode-bookmarks#109

Closed

This was referenced May 7, 2018

Add ability to add a Panel through an extension #41686

Closed

Provide an action to collapse all views except the focussed view #48201

Closed

usernamehw mentioned this issue May 23, 2018

Ability to drag-n-drop views to activity bar #50363

Closed

vscodebot bot locked and limited conversation to collaborators Jun 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ability to contribute views containers #43645

Ability to contribute views containers #43645

sandy081 commented Feb 14, 2018 •

edited

Loading

sandy081 commented Mar 19, 2018 •

edited

Loading

eamodio commented Mar 19, 2018

eamodio commented Mar 19, 2018

sandy081 commented Mar 19, 2018

ghost commented Mar 20, 2018 •

edited by ghost

Loading

rozzzly commented Mar 24, 2018 •

edited

Loading

DanTup commented Mar 26, 2018

eamodio commented Apr 3, 2018

sandy081 commented Apr 17, 2018 •

edited

Loading

eamodio commented Apr 25, 2018

d-akara commented Apr 25, 2018

sandy081 commented Apr 25, 2018

sandy081 commented Apr 25, 2018 •

edited

Loading

eamodio commented Apr 25, 2018

sandy081 commented Apr 25, 2018

eamodio commented Apr 25, 2018

sandy081 commented Apr 25, 2018 •

edited

Loading

eamodio commented Apr 25, 2018

DanTup commented Apr 26, 2018

sandy081 commented Apr 26, 2018

DanTup commented Apr 26, 2018

sandy081 commented Apr 26, 2018

DanTup commented Apr 26, 2018

patrys commented Apr 26, 2018

DanTup commented Apr 26, 2018

sandy081 commented Apr 26, 2018 •

edited

Loading

sandy081 commented Apr 27, 2018

Ability to contribute views containers #43645

Ability to contribute views containers #43645

Comments

sandy081 commented Feb 14, 2018 • edited Loading

sandy081 commented Mar 19, 2018 • edited Loading

Step 1

Step 2

eamodio commented Mar 19, 2018

eamodio commented Mar 19, 2018

sandy081 commented Mar 19, 2018

ghost commented Mar 20, 2018 • edited by ghost Loading

rozzzly commented Mar 24, 2018 • edited Loading

DanTup commented Mar 26, 2018

eamodio commented Apr 3, 2018

sandy081 commented Apr 17, 2018 • edited Loading

eamodio commented Apr 25, 2018

d-akara commented Apr 25, 2018

sandy081 commented Apr 25, 2018

sandy081 commented Apr 25, 2018 • edited Loading

eamodio commented Apr 25, 2018

sandy081 commented Apr 25, 2018

eamodio commented Apr 25, 2018

sandy081 commented Apr 25, 2018 • edited Loading

eamodio commented Apr 25, 2018

DanTup commented Apr 26, 2018

sandy081 commented Apr 26, 2018

DanTup commented Apr 26, 2018

sandy081 commented Apr 26, 2018

DanTup commented Apr 26, 2018

patrys commented Apr 26, 2018

DanTup commented Apr 26, 2018

sandy081 commented Apr 26, 2018 • edited Loading

sandy081 commented Apr 27, 2018

sandy081 commented Feb 14, 2018 •

edited

Loading

sandy081 commented Mar 19, 2018 •

edited

Loading

ghost commented Mar 20, 2018 •

edited by ghost

Loading

rozzzly commented Mar 24, 2018 •

edited

Loading

sandy081 commented Apr 17, 2018 •

edited

Loading

sandy081 commented Apr 25, 2018 •

edited

Loading

sandy081 commented Apr 25, 2018 •

edited

Loading

sandy081 commented Apr 26, 2018 •

edited

Loading