Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support quickSuggestions for jsdoc types #43715

Closed
mjbvz opened this issue Feb 15, 2018 · 0 comments · Fixed by #46001
Closed

Support quickSuggestions for jsdoc types #43715

mjbvz opened this issue Feb 15, 2018 · 0 comments · Fixed by #46001
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug plan-item VS Code - planned item for upcoming verified Verification succeeded
Milestone
March 2018

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Feb 15, 2018 •
edited
Loading

Bug
For the js/ts:

/**
 * @param {|} x
 */
function foo(x) {}

quick suggestions currently not enabled when typing inside the jsdoc type annotation

Possible fix
My original proposed fix was adding a meta.embedded scope to the types: atom/language-javascript#539

It we can't get this fixed in language-javascript, we can add meta.embedded to our TS grammar specifically. I'll keep investigating other possible solutions as well
@mjbvz mjbvz added the plan-item VS Code - planned item for upcoming label Feb 15, 2018
@mjbvz mjbvz self-assigned this Feb 15, 2018
@mjbvz mjbvz added this to the February 2018 milestone Feb 15, 2018
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Feb 15, 2018
@kieferrm kieferrm mentioned this issue Feb 16, 2018
Closed
45 tasks
@mjbvz mjbvz modified the milestones: February 2018, March 2018 Feb 27, 2018
@kieferrm kieferrm mentioned this issue Mar 13, 2018
Closed
70 tasks
mjbvz added a commit to mjbvz/vscode that referenced this issue Mar 16, 2018
@mjbvz
Support quickSuggestions in JSDoc Types
3a7f928 
Fixes microsoft#43715

Requires vscode-textmate 3.3.1 before merging
@mjbvz mjbvz mentioned this issue Mar 16, 2018
Merged
mjbvz added a commit that referenced this issue Mar 16, 2018
@mjbvz
Support quickSuggestions in JSDoc Types (#46001)
d74145e 
* Support quickSuggestions in JSDoc Types

Fixes #43715

Requires vscode-textmate 3.3.1 before merging

* Pick up new vscode textmate version
@tsalinger tsalinger added the verified Verification succeeded label Mar 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug plan-item VS Code - planned item for upcoming verified Verification succeeded
Projects
None yet
Milestone
March 2018
Development

Successfully merging a pull request may close this issue.

Support quickSuggestions in JSDoc Types mjbvz/vscode
2 participants
@mjbvz @tsalinger