Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit breakpoint is larger than its brothers #44550

Closed
joaomoreno opened this issue Feb 27, 2018 · 6 comments
Closed

Edit breakpoint is larger than its brothers #44550

joaomoreno opened this issue Feb 27, 2018 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Feb 27, 2018

Testing #43836

image

@joaomoreno
Copy link
Member Author

Disabled too!

image

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Feb 27, 2018
@isidorn isidorn added this to the February 2018 milestone Feb 27, 2018
@isidorn isidorn closed this as completed in 12e2e2e Mar 1, 2018
@isidorn
Copy link
Contributor

isidorn commented Mar 1, 2018

Thanks for finding this.
I fixed the size of the disabled icon, the conditional was always a bit larger. Though on my screen it is not that large

screen shot 2018-03-01 at 07 31 26

@chryw it seems like the new breakpoint icons you provided are slightly larger than our previous icons. I am personally not a fan of this since I think they already draw too much attention with the red color and increasing the size is not really necessery.
Is it possible for you to decrease the size of the new icons such that they are the same as our previous breakpoint icon?
There is no hurry for this, I would like to do it next milestone if you have the time

@chryw
Copy link
Contributor

chryw commented Mar 1, 2018

@isidorn I see this folder has a mix of old and new icon files. Some files are not made by me. That's probably why they're inconsistent in size and color. I can do a pass on the entire folder. Are these all the debug icons?
#44849 related color issue

@mjbvz mjbvz added the verified Verification succeeded label Mar 1, 2018
@isidorn
Copy link
Contributor

isidorn commented Mar 2, 2018

@chryw yes they are all debug icons and only used there.
It would be brilliant if you could make a pass and provide a PR which fixes these issues.

@chryw
Copy link
Contributor

chryw commented Mar 5, 2018

@isidorn will do this week :-)

@isidorn
Copy link
Contributor

isidorn commented Mar 5, 2018

@chryw great, thanks :)

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants