"Open in Terminal" not working on Fedora

[Coder206]

• VSCode Version: 0.10.11
• OS Version: Fedora 23 (64 Bit)

Steps to Reproduce:

1. Save work
2. Right click in the toolbar
3. Select "Open in Terminal"

[Tyriar]

Reproduced. It gives the error spawn ENOTDIP. It's happening because x-terminal-emulator is not in the PATH on Fedora.

[Tyriar]

x-terminal-emulator is part of the Debian alternatives system which is why this doesn't work.

[pflannery]

There is a PR #3495 that allows Linux users to specify a different terminal other than the hard coded x-terminal-emulator not sure whether it will be accepted or not though

[Tyriar]

@pflannery thanks for pointing that out

[Coder206]

Great thanks @Tyriar and @pflannery

[Tyriar]

#3495 fixes this issue, thanks again @pflannery

[aeschli]

On my freshly installed Fedora 23 install I get the same error as above. That's with VSCode 1.0.1 (April release). Reopening...

[pflannery]

Just did a fresh install of fedora 23 and it works for me.
Did you have a workspace open?

This is the vscode version I tested with

[aeschli]

I'm on the latest build from today that we use for testing
The dev tools console shows: shell.ts:415spawn x-terminal-emulator ENOENT: Error: spawn x-terminal-emulator ENOENT.

[aeschli@localhost workspaces]$ which x-terminal-emulator 
/usr/bin/which: no x-terminal-emulator in (/bin:/usr/bin:/usr/local/bin:/usr/local/sbin:/usr/sbin:/home/aeschli/.local/bin:/home/aeschli/bin)

Is there anything I need to install or configure first?

[Tyriar]

The code for that is here https://github.com/Microsoft/vscode/blob/849abd65ebf3e8c0f807e05639e723d16f8e6e3a/src/vs/workbench/parts/execution/electron-browser/terminal.ts#L9, it should yield gnome-terminal if it uses gnome (not sure if Fedora has other flavors).

I created this to improve the defaults later though I expect it to work #5780

[Tyriar]

Closing in favor of #5780