Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Come up with better external terminal defaults on Linux #5780

Closed
Tyriar opened this issue Apr 25, 2016 · 1 comment
Closed

Come up with better external terminal defaults on Linux #5780

Tyriar opened this issue Apr 25, 2016 · 1 comment
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality linux Issues with VS Code on Linux verified Verification succeeded
Milestone
May 2016

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 25, 2016 •
edited
Loading

Currently the default is x-terminal-emulator unless the OS is not Debian and is gnome in which case it's gnome-terminal. This could be cleaned up and improved to add common non-gnome terminals, something like this:

if is debian
  x-terminal-emulator
if is gnome or gnome-classic
  gnome-terminal
if is other common cases
  some good default
fallback to a reasonable default widely supported? `xterm`?

/cc @pflannery
@Tyriar Tyriar self-assigned this Apr 25, 2016
@Tyriar Tyriar added the feature-request Request for new features or functionality label Apr 25, 2016
@Tyriar Tyriar added this to the May 2016 milestone Apr 25, 2016
This was referenced Apr 27, 2016
Closed
Closed
Tyriar added a commit that referenced this issue May 14, 2016
@Tyriar
Improve Linux external terminal defaults
4d215d8 
Related #5780
@Tyriar Tyriar closed this as completed in 9cff38a May 14, 2016
@Tyriar Tyriar added the linux Issues with VS Code on Linux label May 14, 2016
@Tyriar
Copy link
Member Author

Tyriar commented May 14, 2016

Verified on Ubuntu (x-terminal-emulator), Xubuntu (xfce4-terminal) RHEL7 (gnome-terminal [via gnome-classic]) and Fedora (gnome-terminal [fixes #4478])

@Tyriar Tyriar added the verified Verification succeeded label May 14, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Milestone
May 2016
Development

No branches or pull requests
1 participant
@Tyriar