Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CentOS fails to launch any terminal by default #5842

Closed
joaomoreno opened this issue Apr 26, 2016 · 4 comments
Closed

CentOS fails to launch any terminal by default #5842

joaomoreno opened this issue Apr 26, 2016 · 4 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
May 2016

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Apr 26, 2016 •
edited
Loading

Testing #5463

CentOS comes with gnome-terminal installed, yet Code fails to launch it. It fails to launch any terminal, actually.

This detection might be too overzealous.

Here's the reason:

[joao@localhost]~% echo $DESKTOP_SESSION 
gnome-classic
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Apr 26, 2016
@joaomoreno joaomoreno changed the title CentOS fails to launch a terminal by default CentOS fails to launch any terminal by default Apr 26, 2016
@joaomoreno
Copy link
Member Author

Setting "externalTerminal.linuxExec": "gnome-terminal" works.

@Tyriar
Copy link
Member

Tyriar commented Apr 27, 2016

It would be pretty easy to change the logic to include gnome-classic as well to prevent a possible regression in April if you want to do that @joaomoreno, #5780 is planned to improve upon this in the long term.

@Tyriar Tyriar added this to the May 2016 milestone Apr 27, 2016
@joaomoreno
Copy link
Member Author

Not critical, no.

@Tyriar
Copy link
Member

Tyriar commented May 13, 2016

Closing in favor of #5780

@Tyriar Tyriar closed this as completed May 13, 2016
@Tyriar Tyriar added the verified Verification succeeded label May 23, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
May 2016
Development

No branches or pull requests
2 participants
@joaomoreno @Tyriar