Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git amend: Line break is removed #45115

Closed
tsalinger opened this issue Mar 6, 2018 · 10 comments
Closed

Git amend: Line break is removed #45115

tsalinger opened this issue Mar 6, 2018 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) git GIT issues
Milestone

Comments

@tsalinger
Copy link
Contributor

Problem: Trying to amend a previous commit which contains line breaks. The line breaks are not preserved in the quick picker.

gitamendnolinebreaks

Would it be a worse UX if the commit message was shown in the intial commit input box instead of the quick picker?

@joaomoreno
Copy link
Member

@tsalinger It's a good idea to populate the input box instead, but it'll be hard to remember that the next commit will be an amended one. What if the user wants to cancel it?

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Mar 6, 2018
@joaomoreno joaomoreno added this to the Backlog milestone Mar 6, 2018
@tsalinger
Copy link
Contributor Author

Hmm... I see the problem.
A quickfix could be to display and parse the line breaks in the quickpick.

A more sophisticated approach would be to add a showMessage of type info to the inputBox.
It would notify the user that a) it's currently in an amend operation and b) that ESC aborts it.
However, I'm not sure how well this would integrate into the current workflow.

@tsalinger
Copy link
Contributor Author

@chrmarti this might be another scenario to consider for your quickpick exploration?

@dmstern
Copy link

dmstern commented Mar 30, 2018

It's a good idea to populate the input box instead, but it'll be hard to remember that the next commit will be an amended one. What if the user wants to cancel it?

@joaomoreno This could be solved by #46994.

@robsonsobral
Copy link

This is speacially annoying when using Jira Smart commits.

@madig
Copy link

madig commented Jun 14, 2018

Atom solves this nicely.

@jbrundage
Copy link

I would greatly appreciate this issue being resolved.

@eamodio
Copy link
Contributor

eamodio commented Jul 19, 2018

This is a duplicate of this #40295 right?

@myrdd
Copy link

myrdd commented Sep 11, 2018

@eamodio I think so, too

@joaomoreno joaomoreno added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 18, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 18, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Sep 18, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) git GIT issues
Projects
None yet
Development

No branches or pull requests

8 participants