-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore richer quick-pick support #45589
Comments
Collecting a few recordings of current workarounds in OneNote. Some obvious issue:
|
Any chance #45869 can be included in the investigation/exploration? |
@eamodio We'll keep that in mind, but it won't make the high priority list at this time. Everyone: Here are some variations on the single item picker in the multi step flow:
I also include the previous variants at the end for reference. |
@chrmarti Thanks. My 2c — I much prefer the 2nd option (grouped actions) as it is easier to navigate with the keyboard and feels more extensible. At the same time, the 3rd option is also interesting, especially if it can be mixed with the 2nd option (if desired). It seems like option 2 adds support to the quick pick for grouping, while option 3 adds support for a navigation group. Both of which I can see being useful (and also very similar in to menu commands). |
A few things:
|
Good points. It has been pointed out that one issue with 1) is that the buttons change vertical position when the list is filtered and when moving between steps. That makes 3) and maybe 4) the preferred options for now. I will do some more mockups. |
Going with the toolbar to the right of the filter field for now. Here are two more sets of mockups: Both show the 3 input types (single-select, multi-select and single-line text) after each other as they might appear in a multi-step input sequence. The second one adds a title area that holds the title the number of steps and the toolbar. |
How extensible will those options be? Is it similar to the navigation group for menus? Will things need to be known completely up-front or will you be able to control/change them at each step? I can see some of this being applicable to GitLens, but in my case there isn't a known number of steps. |
I haven't spent much time thinking about the API yet. You would probably pass the actions with each step, with the back and forward actions being given. The number of steps could be updated along the way or omitted. |
Would it also be possible to make it more decorable? Something like adding a small color-indicator next to items. |
@HoboKristian That is very likely beyond the scope of this issue. Please check if any of the issues listed above in the description cover your case and create a new issue if not. Thanks. |
Would it support cross extension navigation? like extension A invoke a command of extension B, then the 'back' Button / Action can pull back to extension A. |
Implemented the multi-select picker and did mockups for multi-step input for March. Closing as this concludes the exploration. Will track additional work in new issues. |
@ArthurMa1978 Cross-extension navigation might be possible with the close cooperation of both extensions. But I don't have a draft of the API yet, so it is hard to tell for sure at the moment. |
@chrmarti got it, let's check once the API is ready, thanks a lot ! |
Join the API discussion here: #49340 |
Related: #238, #11468, #16445, #20944, #21372, #23633, #34088, #35785, #35993, #38225, #39969, #45214, #45466, #45583.
The text was updated successfully, but these errors were encountered: