Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support language specific intellisense in breakpoints conditions and logMessage peek UI #45127

Closed
weinand opened this issue Mar 6, 2018 · 1 comment
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Mar 6, 2018

related issue (but not a duplicate): #11692

Additional info:

  • turn current condition text box into an editor (so that we can use the Intellisense infrastructure),
  • one way to get Intellisense is to programmatically trigger a completion command for the breakpoint's line and underlying file. From the resulting list of completion items you can extract interesting items (e.g. those with kind Variable) or use all,
  • for the LogPoint's text box language Intellisense is only needed within the curly braces:
    { Date.now() }: this is a log message with a variable value: { x }
    Outside of the curly braces Intellisense could just suggest the curly braces.

Example from VS for Mac:

2018-03-21_10-17-57

@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Mar 6, 2018
@weinand weinand added this to the March 2018 milestone Mar 6, 2018
@weinand weinand modified the milestones: March 2018, April 2018 Mar 26, 2018
@isidorn
Copy link
Contributor

isidorn commented Mar 26, 2018

Done via #46540

@isidorn isidorn closed this as completed Mar 26, 2018
@isidorn isidorn modified the milestones: April 2018, March 2018 Mar 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

2 participants