Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split html, css and json to basic and language feature extensions #45900

Closed
3 tasks done
octref opened this issue Mar 15, 2018 · 2 comments
Closed
3 tasks done

Split html, css and json to basic and language feature extensions #45900

octref opened this issue Mar 15, 2018 · 2 comments
Assignees
@octref @aeschli
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality html HTML support issues json JSON support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2018

Comments

@octref
Copy link
Contributor

octref commented Mar 15, 2018 •
edited
Loading

  • html
  • json
  • css
@octref octref added css-less-scss Issues and items concerning CSS,Less,SCSS styling html HTML support issues json JSON support issues labels Mar 15, 2018
@octref octref added this to the March 2018 milestone Mar 15, 2018
@kieferrm kieferrm mentioned this issue Mar 16, 2018
Closed
70 tasks
aeschli added a commit that referenced this issue Mar 17, 2018
@aeschli
[json] split json extension (for #45900)
5b23587
aeschli added a commit that referenced this issue Mar 17, 2018
@aeschli
[html] split extension (for #45900)
086a751
@aeschli
Copy link
Contributor

aeschli commented Mar 17, 2018 •
edited
Loading

The new extensions are named html-language-features and json-language-features, matching markdown-language-features and typescript-language-features.
I also named the folders in the repo the same way (extensions/html-language-features). That's not consistent with markdown and typescript but I prefer keeping extension name and folder the same. @mjbvz What do you think, can we do the same for markdown and typescript?

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 20, 2018

I'll rename them too. I was originally concerned that it would mess up localization

octref added a commit that referenced this issue Mar 20, 2018
@octref
[css] split extension (for #45900)
c52149e
@octref octref closed this as completed Mar 20, 2018
@aeschli aeschli added verification-needed Verification of issue is requested feature-request Request for new features or functionality labels Mar 27, 2018
@mjbvz mjbvz added the verified Verification succeeded label Mar 27, 2018
DeltaEvo added a commit to vscode-langservers/extractor that referenced this issue Apr 12, 2018
@DeltaEvo
Follow microsoft/vscode#45900
32606f0
@vscodebot vscodebot bot locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

@aeschli aeschli

Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality html HTML support issues json JSON support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2018
Development

No branches or pull requests
3 participants
@octref @aeschli @mjbvz