Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local variables are not suggested in log message completions #46824

Closed
alexdima opened this issue Mar 28, 2018 · 5 comments
Closed

Local variables are not suggested in log message completions #46824

alexdima opened this issue Mar 28, 2018 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

Testing #45962

  • add a log point
  • very likely, in a log point, you might want to log the value of a local variable or argument to a function (i.e. not global variables)
  • observe, the local variables are not suggested

image

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Mar 28, 2018
@isidorn
Copy link
Contributor

isidorn commented Mar 28, 2018

@alexandrudima there are quite some flaws with our current suggest approach
However I changed that I get the inteli-sense for the location of my breakpoint and not for the start of the document, this shuold make it more precise and I expect to fix this case.
In case it does not get fixed it might be an related to https://slack-redir.net/link?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvscode%2Fissues%2F46827

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Mar 28, 2018
@isidorn isidorn added this to the March 2018 milestone Mar 28, 2018
@ramya-rao-a ramya-rao-a reopened this Mar 30, 2018
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Mar 30, 2018

While I do see completions, they seem to skip the first letter and use the rest

In the example that @alexandrudima provided above, we get completions for r instead of nr

In the below example, we get completions for urr instead of curr

screen shot 2018-03-30 at 2 58 46 pm

Same thing in the issue that @RMacfarlane logged #46739

cc @jrieken

@sandy081 sandy081 removed this from the March 2018 milestone Apr 3, 2018
@weinand weinand added this to the April 2018 milestone Apr 3, 2018
@weinand
Copy link
Contributor

weinand commented Apr 3, 2018

@isidorn I have disabled Intellisense for now with commit 18e3868

@isidorn
Copy link
Contributor

isidorn commented Apr 25, 2018

@weinand with the help of Joh this now behaves much better imho. Please try it out and if we decide to include it we can put it in release notes (I guess we did not do it last release)

@weinand
Copy link
Contributor

weinand commented Apr 25, 2018

@isidorn yes works better now. Let's ship this.

@weinand weinand added verification-needed Verification of issue is requested release-notes Release notes issues verified Verification succeeded labels Apr 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants