Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal links are offset after CJK characters #47871

Closed
hoxily opened this issue Apr 14, 2018 · 7 comments
Closed

Terminal links are offset after CJK characters #47871

hoxily opened this issue Apr 14, 2018 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded

Comments

@hoxily
Copy link

hoxily commented Apr 14, 2018

Issue Type: Bug

在终端里面输入可以被识别的url链接后,如果链接前面还有中文字符,就会出现下划线以及相应的Ctrl+点击响应区域都向左偏。

如图所示例子:https://img.vim-cn.com/74/13cb93b28d38306c8c247bd80039b5882511f8.png
vsc url link underline bug

VS Code version: Code 1.22.2 (3aeede7, 2018-04-12T16:38:45.278Z)
OS version: Windows_NT x64 10.0.15063

System Info
Item Value
CPUs Intel(R) Core(TM) i3-7100 CPU @ 3.90GHz (4 x 3912)
Memory (System) 7.90GB (0.53GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader no
VM 0%
Extensions (7)
Extension Author (truncated) Version
python ms- 2018.3.1
csharp ms- 1.14.0
java red 0.22.0
vscode-java-debug vsc 0.8.0
vscode-java-pack vsc 0.3.0
vscode-java-test vsc 0.5.0
vscode-maven vsc 0.7.0
@jinyuzu99
Copy link

提issue最好用英文啊, 老外又看不懂
It’s better to submit issue in English

@pansila
Copy link

pansila commented Apr 14, 2018

Translation:
All URLs preceded by Chinese characters have an underline offset and respond to the click event in an area to the left of the actual clicked place.

@alexdima
Copy link
Member

This appears to be in the terminal

@alexdima alexdima assigned Tyriar and unassigned alexdima Apr 16, 2018
@Tyriar
Copy link
Member

Tyriar commented Apr 16, 2018

This just came through in the upstream repo too, not a regression xtermjs/xterm.js#1387

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal General terminal issues that don't fall under another label labels Apr 16, 2018
@Tyriar Tyriar added this to the Backlog milestone Apr 16, 2018
@Tyriar Tyriar changed the title 终端的链接识别在有汉字的情况下,下划线以及相应的Ctrl+点击响应区域都向左偏了 Terminal links are offset after CJK characters Apr 16, 2018
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Sep 12, 2018
@Tyriar
Copy link
Member

Tyriar commented Sep 17, 2018

This should be fixed in tomorrow's insiders.

@Tyriar Tyriar closed this as completed Sep 17, 2018
@Tyriar Tyriar modified the milestones: Backlog, September 2018 Sep 17, 2018
@octref
Copy link
Contributor

octref commented Sep 27, 2018

This still doesn't work correctly:

image

Repro:

echo "http://www.baidu.com/s?wd=中文"
echo "http://www.baidu.com/s?wd=%E4%B8%AD%E6%96%87"

@octref octref reopened this Sep 27, 2018
@Tyriar
Copy link
Member

Tyriar commented Sep 28, 2018

@octref that's a different issue deferred to xtermjs/xterm.js#583

This one is specifically about CJK before the link offsetting the links.

@Tyriar Tyriar closed this as completed Sep 28, 2018
@octref octref added the verified Verification succeeded label Sep 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants