Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkifier: underline shift after double width character #1387

Closed
mandel59 opened this issue Apr 13, 2018 · 2 comments
Closed

Linkifier: underline shift after double width character #1387

mandel59 opened this issue Apr 13, 2018 · 2 comments

Comments

@mandel59
Copy link

mandel59 commented Apr 13, 2018

Linkifier doesn't support East Asian Width (wcwidth) yet

Details

  • Browser and browser version: any
  • OS version: any
  • xterm.js version: master (da8151b)

Steps to reproduce

  1. Write any URL after East Asian Wide or Fullwidth (a.k.a double width) characters

image

@Tyriar
Copy link
Member

Tyriar commented Apr 13, 2018

This will involve making Linkifier.ts aware of wide characters similar to how SelectionManager.ts is. This can make the code a lot more complex:

private _getWordAt(coords: [number, number], allowWhitespaceOnlySelection: boolean): IWordPosition {

I wonder if there's a nicer, more generic way to deal with converting between character indexes and column numbers.

@Tyriar
Copy link
Member

Tyriar commented Sep 17, 2018

Works in master 🎉

@Tyriar Tyriar closed this as completed Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants