-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editor.action.sortLinesAscending has confusing sort order for symbols #48123
Comments
Thanks for your response - interesting that the editor uses the same sort as the UI! I use the sort function most often to sort lines in code, which usually contain only ASCII characters. The issue I (personally) have with the current vscode sort function is that when I pipe the file content into other utilities, those utilities expect lines to be in ASCII order. Regarding the sorting of files in vscode's explorer, Windows explorer sorts the files as I would expect: Sorting in ASCII order is beneficial as shorter filenames are placed before longer ones. Since this is supposed to be a general sort & is also applied to UI elements, it's difficult to come up with a one-size-fits-all solution. Personally, I would introduce two settings:
Perhaps these settings could be separate from the sorting in the explorer, e.g. |
I'm currently sorting a very long YAML file in order for it to pass yamllint configured to enforce lexical sorting of keys. This issue is of interest to me because currently Code's idea of a lexical sort and After Code ---
underscore_underscore: second
underscore: first yamllint output:
|
Yeah, I've run across this issue with the sort method as well. One problem is that if you use unicode integer representations to sort, it will always be confusing. And you sort of have to use unicode to sort, since that's what we use in our editors nowadays. For example: So, the following would be in VSCode sort order:
And so would the following:
I believe this is because it uses the |
I find it wrong that despite 99.999% of files in the world of coding use only ASCII in names and content, VSCode defaults to sorting in an unexpected way just so 0.001% of unicode cases could be satisfied. Unicode collation is for natural languages but programmer's editor/IDE more often than not deals with computer languages so is defaulting to I wonder if there can be some compromise sorting option that satisfies both needs. Similar to how natural order sorting puts |
For someone looking to fix this in the Explorer, this config can help in many cases: |
Three years and 17 upvotes later and not a peep from the developers. I get that there's a lot going on, but this can't really be that difficult to address, right? |
I think this issue has two aspects:
(1) can easily be implemented by an extension that offers some kind of "Sort Lines ASCII" command. As of 2), changing the default can be risky if some users got used to the current default. |
Interesting that a similar issue was closed 6 years ago since this is "as designed": #15516 They used this example
However
|
similar issues... with what i write as correctly sorted...
when it is auto sorted, it switches the order
i want to keep the shorter version first, with the following with additional granularity after, im sure this has been discussed before, but was unable to find anything. i have played around with various i get |
Looks like such big corporation does not care about, what ants want. |
Can we have at least the ability to override the sorting in the settings? It would solve the issue almost for 99% of people. I am pretty sure a lot of people using built in sorting abilities of IDE and this issue is frustrating. We also have this issue regarding |
Can I ask for the same for Sorting like
would be great, there is no option to achieve this today. |
How about special characters vs alphabetic characters (lower and upper)? For example:
|
|
sort <<< '
Z
z
A
a
'
|
#97272 added sorting option for explorer
it would be nice to have a similar option for editor
some option should be applied in following location
|
When sorting lines using
editor.action.sortLinesAscending
("Sort Lines Ascending" via the Command Palette) the lines are sorted in a very strange order when the comparison involves a symbol character.I would expect that
.
(period) would be sorted before_
(underscore) because in ASCII, period is 46 and underscore is 95.However, vscode uses
localeCompare
as its sorting method (see sortLinesCommand.ts:76), which results in underscore being sorted before period. See the repro steps below for an example.I saw a previous issue regarding this (#15516) but it was closed because the ASCII ordering was in fact correct. In the case I've outlined below, the ordering is not correct.
I'm not sure what the correct solution would be but I think that for ASCII symbols, ASCII ordering should be obeyed. I do realise that "Sort Lines Ascending" is an ambiguous term - ascending according to what criteria? - so perhaps the command could be renamed to something more specific, or you could provide different default sorting options.
Steps to Reproduce:
Highlight the file contents.
Open the Command Palette and select "Sort Lines Ascending".
Expected:
The file is sorted in the following order:
Actual:
The file is sorted in the following order:
Does this issue occur when all extensions are disabled?: Yes
The text was updated successfully, but these errors were encountered: