Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

managed_modules.yml: sort modules alphabetically #933

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bastelfreak
Copy link
Member

No description provided.

Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add some rspec to check that the list is sorted?

@kenyon
Copy link
Member

kenyon commented Sep 17, 2024

Note that order depends on how the sort is implemented. For example, Visual Studio Code's built-in sort function works differently than the coreutils sort command: microsoft/vscode#48123

So it would be good to have a standard way of doing it, like with a rake task, and a verification method, like @jhoblitt says.

@jhoblitt
Copy link
Member

I have a close enough copy of coreutils sorting behavior to use it in a spec file. https://github.com/lsst-it/lsst-control/blob/production/spec/unit/puppetfile_spec.rb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants