-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest Electron 1.7.x #49899
Comments
(Experimental duplicate detection) |
We should ideally wait for |
I don't think we're impacted by this, @mjbvz? |
No I wasn't able to exploit it using a custom webview extension that has no csp and enables scripts. I believe we also block mounting unknown webviews if there happened to be an html injection in the main product |
@mjbvz Many thanks for investigating it! |
I think we will probably just go to 2.0.x directly. Closing as duplicate of #45542 |
Please update Electron version whenever new release with a fix is available. The reason for that is:
As far I understand, the current version is 1.7.12
https://github.com/Microsoft/vscode/blob/master/.yarnrc
more info:
https://www.trustwave.com/Resources/SpiderLabs-Blog/CVE-2018-1000136---Electron-nodeIntegration-Bypass/
Many thanks in advice!
The text was updated successfully, but these errors were encountered: