Explore to update to Electron 2.0.x #45542
Comments
This comment has been minimized.
This comment has been minimized.
|
How do I test this thing? I just upgraded to Nvidia 390.42 and this seems to have fixed my X crash issue but I'm keen to help test out this branch. Is there a tag or branch to check out to get these builds? I run Arch so debs and rpms are not relevant to my system. |
|
What's the main difference(s), to look out for? |
|
Works for me, so far, with all my favorite extensions, themes, and user settings. Where would I copy over snippets etc. from Insiders to this one? |
|
@l0k1verloren this build is from branch https://github.com/Microsoft/vscode/tree/tyriar/electron-2.0.x. Best way to test it is to use it for daily development and report back if you encounter any issues 👍 @smlombardi visually nothing should change really. On Linux, since GTK3 is now used (over GTK2) some file dialogs and menus will likely look different. You will have to manually copy settings and keybindings over to this build as nothing is shared. Just open the files in one instance and copy the contents over to the other. |
|
I switched to the tyriar/electron-2.0.x branch and built and ran it and it seemed normal (exceept nice gtk3 file dialog) but then when it opened a folder nothing rendered and the menus didn't respond. |
|
@l0k1verloren on what Linux distribution are you? can you show a screenshot or video what you see? |
|
Initial startup:
After opening a (golang) repository folder:
|
|
@l0k1verloren and this works fine with VS Code stable? Do you see any output in the developer console (Help > Toggle Developer Tools > Console) when you bring up the dialog? |
|
Something is off with the menu bar colors for me - it's white on light grey with the Breeze GTK3 theme. |
|
@K900 this Electron update comes with a change of GTK2 to GTK3, so I am expecting visual changes in native menus and file dialogs. Can you share a screenshot? Does it look different from other application menus? |
|
It's not an issue in, say, gtk3-demo:
|
|
@K900 can you confirm that you are not seeing this with Code stable? |
|
Everything is fine on stable (GTK2), yeah.
|
|
@K900 have you seen this issue with other applications on your machine (e.g. Chrome)? |
|
@l0k1verloren do you have Chrome installed? I wonder if you could try the file dialog there to see if it fails too (File > Open File). |
|
Chrome doesn't have a menu bar, does it? Firefox does have a menu bar, but it uses the Firefox theme colors. All the GTK3 demo apps use the correct colors. |
|
@K900 yeah good point, how does the context menu in VSCode look like, is it also using bad colors? |
|
The context menu is fine, it's just the menu bar that's using the wrong font color. |
|
@K900 does it also reproduce if you are not using any special theme? |
|
Happy to report it (2018-03-13T14:22:28) seems to work very nicely on Debian testing with Adwaita Dark themed GTK3 and it's nice to see the old GTK2 parts gone. The only minor cosmetic thing I noticed is that the editor background color is dark greyish on lines with text and a few more after file end but then turns black. The same applies to the line number pane. Looking forward to this major update of this excellent editor. |
|
@bpasero what do you mean by "special" theme? Just default Adwaita? |
|
@K900 I thought "Breeze GTK3 theme" was a special theme you enabled @bjornharrtell can you show me a screenshot of that? |
|
Breeze is just a GTK theme like any other, it's styled to look like the default KDE Breeze style for Qt. I can try it with the default GTK3 theme that GNOME uses. |
|
I downloaded this exploration build and took it for a spin. Specifically, I wanted to check out the native tabs on High Sierra. The Native Tabs functionality is not fixed, even with Electron 2 in the build*. I tested the contributed phoenixgao build some time ago and it worked. @bpasero I'm recalling some comments over there - is the key here that the Electron package must be built on a High Sierra machine? If so, how can this ever be fixed properly? High Sierra 10.13.2 (17C88)
|
|
@johnelm Electron did NOT fix this issue properly. As soon as a new macOS version is released, the issue will show up again. I would suggest to join me in blaming the "fix" here: electron/electron#10657 (comment) We are building Electron ourselves and have a different build configuration compared to GitHub. As such, the "fix" does not work for us and I mentioned that. |
|
Merged to master. |
|
Reverted this change again, too many bugs and regressions... |
|
@bpasero In my opinion, Would you please think about update to Electron 3.x directly? |
|
@LiPengfei19820619 we're looking at that as well, it's probably a little naive to assume there won't be just as many issues adopting it too though. |
|
@Tyriar Yes, I Know. I don't think it would be an easy work. I appreciate all your job, |
|
Merged into master, the latest Insiders is on 2.0.5 #54873 |
Hey!
We are in the process of updating VSCode’s Electron version to a new major release (from 1.7.x to 2.0.x). For that reason we would like to get some testers onto this version, which we currently not plan to distribute via insiders but as a separate install that can be run side-by-side with other installs. This install is separate with regards to everything (settings, keybindings, extensions), so it will not touch any of your existing configuration.
Best way of testing is to just use this build for daily development and look out for suspicious things happening 👍 . Visually there should be no difference to stable or insiders (except for the orange icon 🔶).
Builds
Feel free to file issues as you see them, thanks 👍
The text was updated successfully, but these errors were encountered: