Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron 2.0.5 #54873

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Electron 2.0.5 #54873

merged 2 commits into from
Jul 25, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 23, 2018 •
edited
Loading

This reverts #54854

#45542

@Tyriar
Revert "Merge pull request #54854 from Microsoft/revert-52782-electro…
5dc414c 
…n-2.0.x"

This reverts commit 90fc7e6, reversing
changes made to 3b25417.
@Tyriar Tyriar added this to the July 2018 milestone Jul 23, 2018
@Tyriar Tyriar self-assigned this Jul 23, 2018
@Tyriar Tyriar mentioned this pull request Jul 23, 2018
Closed
@Tyriar Tyriar merged commit 5fae91d into master Jul 25, 2018
@Tyriar Tyriar mentioned this pull request Jul 25, 2018
Closed
jens1o
jens1o reviewed Jul 25, 2018
View reviewed changes
src/main.js
@@ -81,6 +81,13 @@ if (isTempPortable) {

const app = require('electron').app;

// TODO@Ben Electron 2.0.x: prevent localStorage migration from SQLite to LevelDB due to issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which issues @Tyriar?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was resolved @bpasero

@manfredbrandl manfredbrandl mentioned this pull request Jul 31, 2018
Merged
@bpasero bpasero deleted the tyriar/electron-2.0.x branch August 6, 2018 05:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jens1o jens1o jens1o left review comments

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
July 2018
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @jens1o