Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken #54852

Closed
isidorn opened this issue Jul 23, 2018 · 4 comments
Closed

Build broken #54852

isidorn opened this issue Jul 23, 2018 · 4 comments
Assignees
Labels
important Issue identified as high-priority
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 23, 2018

Electron update broke the build, this commit a7095d7

Erros can be found here https://monacotools.visualstudio.com/Monaco/_build/results?buildId=40314
Seems like for some reason he fails to download the node-debug / node debug-2 extension, even though there is nothing wrong with them.
Please note that building locally works for me, error only happens in the build agent.

fyi @weinand

@isidorn isidorn added important Issue identified as high-priority electron-update labels Jul 23, 2018
@isidorn isidorn added this to the July 2018 milestone Jul 23, 2018
@sandy081
Copy link
Member

@Tyriar I have reverted the PR related to electron update so that we can have builds. - #54854

@sandy081
Copy link
Member

Also just be aware to handle distro commit correctly. I see that the PR merged an old distro commit.

@sandy081
Copy link
Member

After bit more investigation, it looks like the build is failing while downloading the Electron v2.0.5 from the repo. Looks like the repo does not has it hosted.

@Tyriar
Copy link
Member

Tyriar commented Jul 23, 2018

Thanks for reverting, closing this in favor of #45542 and #54873

@Tyriar Tyriar closed this as completed Jul 23, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

3 participants