Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search highlighting in some themes could be improved #5052

Closed
vsccarl opened this issue Apr 6, 2016 · 2 comments
Closed

Search highlighting in some themes could be improved #5052

vsccarl opened this issue Apr 6, 2016 · 2 comments
Assignees
Labels
themes Color theme issues
Milestone

Comments

@vsccarl
Copy link

vsccarl commented Apr 6, 2016

  • VSCode Version: 0.10.12-alpha (latest)
  • OS Version: Windows 10

Steps to Reproduce:

  1. Search for something that occurs in a file many times
  2. Click between the results in the same file.

Actual:
Very low visibility that your selection has changed between the results in the same file.

searchselection

Also with the Solarized Light theme some text is almost unreadable when selected by search
searchunreadable

@vsccarl vsccarl added the v-test label Apr 6, 2016
@alexdima alexdima self-assigned this Apr 7, 2016
@egamma egamma removed the v-test label Aug 22, 2016
@nathantschultz
Copy link

It would be nice if the user could customize the search results highlight color. It's really hard to tell what is highlighted and what isn't when searching.

@alexdima alexdima added the themes Color theme issues label Aug 29, 2016
@alexdima alexdima added this to the August 2016 milestone Aug 29, 2016
@alexdima alexdima assigned sandy081 and unassigned alexdima Aug 29, 2016
@sandy081
Copy link
Member

This is fixed by #11095

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
themes Color theme issues
Projects
None yet
Development

No branches or pull requests

5 participants