Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract the colors defined by editor as vs code custom settings in themes #11095

Closed
11 tasks done
sandy081 opened this issue Aug 29, 2016 · 1 comment
Closed
11 tasks done

Extract the colors defined by editor as vs code custom settings in themes #11095

sandy081 opened this issue Aug 29, 2016 · 1 comment
Assignees
@sandy081
Labels
feature-request Request for new features or functionality themes Color theme issues
Milestone
August 2016

Comments

@sandy081
Copy link
Member

sandy081 commented Aug 29, 2016 •
edited
Loading

Currently editor has feature contributions those define some colors which does not go well with different themes. Extract those colors as vs code custom settings (non standard) in TM themes. This will allow theme writers to provide an appropriate matching color for these features.

Range highlight (Find, Go to line, Go to symbol)

  • rangeHighlight

Find / Replace (Find, Search, Reference)

  • findMatchHighlight
  • currentFindMatchHighlight
  • findRangeHighlight

Selection

  • inactiveSelection
  • selectionHighlight

Words

  • wordHighlight
  • wordHighlightStrong

Link

  • activeLinkForeground

Hover

  • hoverHighlight

References

  • referenceHighlight

Editor Decorations
@sandy081 sandy081 added feature-request Request for new features or functionality themes Color theme issues labels Aug 29, 2016
@sandy081 sandy081 added this to the August 2016 milestone Aug 29, 2016
@sandy081 sandy081 self-assigned this Aug 29, 2016
This was referenced Aug 29, 2016
Closed
Closed
sandy081 added a commit that referenced this issue Aug 29, 2016
@sandy081
group feature specific styling rules #11095
e6132ea
@sandy081 sandy081 mentioned this issue Aug 29, 2016
Closed
1 task
@kieferrm kieferrm mentioned this issue Aug 30, 2016
Closed
@sandy081 sandy081 mentioned this issue Aug 31, 2016
Closed
@alexdima
Copy link
Member

@sandy081 findSelection and findSelectionHighlight look funny, maybe better names would be findMatchHighlight, currentFindMatchHighlight ?

@sandy081 sandy081 mentioned this issue Aug 31, 2016
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
feature-request Request for new features or functionality themes Color theme issues
Projects
None yet
Milestone
August 2016
Development

No branches or pull requests
2 participants
@alexdima @sandy081