Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal find should center results in viewport #50623

Closed
isidorn opened this issue May 29, 2018 · 1 comment
Closed

Terminal find should center results in viewport #50623

isidorn opened this issue May 29, 2018 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
July 2019

Comments

@isidorn
Copy link
Contributor

isidorn commented May 29, 2018

Refs: #50499

You probably already have issues that the find widget is getting in the way of results in the terminal.

Here I want to suggest a simple heuristic to make it come in the results less frequently.
When a find result is hit you always reveal it on the first line -> thus the chance of it overlapping with the find widget is very hight
Editor always reveals the find resutls in the center of the screen. I suggest that you do the same.
Editor has some nice methods like center if outside viewport, I would expcet the same behavior in the terminal
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues labels May 29, 2018
@Tyriar Tyriar added this to the Backlog milestone May 29, 2018
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jun 25, 2018
@Tyriar Tyriar changed the title Terminal find in the way of results Terminal find should center results in viewport Sep 17, 2018
@Tyriar
Copy link
Member

Tyriar commented Sep 17, 2018

Related: #46561

@alexr00 alexr00 mentioned this issue Sep 26, 2018
Closed
@lramos15 lramos15 self-assigned this Jul 2, 2019
@lramos15 lramos15 mentioned this issue Jul 2, 2019
Merged
@lramos15 lramos15 modified the milestones: Backlog, July 2019 Jul 3, 2019
@Tyriar Tyriar closed this as completed in ada8fd3 Jul 3, 2019
Tyriar added a commit that referenced this issue Jul 3, 2019
@Tyriar
xterm-addon-search@0.2.0-beta2
e3cd9c2 
Fixes #50623
@lramos15 lramos15 added the verified Verification succeeded label Jul 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 17, 2019
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
xterm@3.15.0-beta66
0651da8 
Diff: xtermjs/xterm.js@96eafd3...c55e938

Changes:

- WebGL PR merged
- wordSeparator option
- Layering refactors
- Benchmark merged in
- declarationMap
- tslint clean
- Lower z-indexes (already fixed in vscode)
- Guard against floats in API
- Reset isWrapped on windows
- Centered scroll
- Fix selecting half of double width chars

Fixes microsoft#50623
Fixes microsoft#76526
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
xterm-addon-search@0.2.0-beta2
1a62ebc 
Fixes microsoft#50623
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
July 2019
Development

No branches or pull requests
3 participants
@isidorn @Tyriar @lramos15