Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad sizing when running layoutEditorGroups twice #50674

Closed
aeschli opened this issue May 29, 2018 · 1 comment
Closed

Bad sizing when running layoutEditorGroups twice #50674

aeschli opened this issue May 29, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented May 29, 2018

Testing #50458

  • add a new keybinding
    {
        "key": "Ctrl+0",
        "command": "layoutEditorGroups",
        "args": {
            "orientation": 1,
            "groups": [{ "size": 0.2 }, { "size": 0.2 }, { "size": 0.6, "groups": [{}, {}] }]
        }
    }
  • invoke the keybinding: new empty groups are added with the sizes as specified
  • invoke the keybinding again: the groups are resized, not following the sizes as specified
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-editor-grid Grid layout issues in the editor area labels May 29, 2018
@bpasero bpasero added this to the May 2018 milestone May 29, 2018
@bpasero bpasero modified the milestones: May 2018, June 2018 May 31, 2018
@bpasero bpasero changed the title rerunning layoutEditorGroups applies wrong sizes Bad sizing when running layoutEditorGroups twice May 31, 2018
@bpasero
Copy link
Member

bpasero commented Jun 1, 2018

Adding @joaomoreno, as discussed this would need a bit of support from the grid widget to deserialize a set of groups with certain layout.

@bpasero bpasero closed this as completed Jun 11, 2018
@mjbvz mjbvz added the verified Verification succeeded label Jun 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Development

No branches or pull requests

4 participants