Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support grid descriptors #51337

Merged
merged 6 commits into from
Jun 11, 2018
Merged

Support grid descriptors #51337

merged 6 commits into from
Jun 11, 2018

Conversation

joaomoreno
Copy link
Member

@joaomoreno joaomoreno commented Jun 7, 2018

This lays the foundation for #50674.

The createSerializedGrid function lets you convert a grid descriptor (same interface as the argument of the layoutEditorGroups command) and that will return a SerializedGrid instance.

You can then throw the entire grid away and use that instance to create a new SerializedGrid, using a special deserializer which reuses old editor groups from an array, as discussed.

@bpasero I'll leave the rest up to you!

@joaomoreno joaomoreno added the workbench-editor-grid Grid layout issues in the editor area label Jun 7, 2018
@joaomoreno joaomoreno added this to the June 2018 milestone Jun 7, 2018
@bpasero
Copy link
Member

bpasero commented Jun 7, 2018

@joaomoreno thanks will have a look

@bpasero bpasero merged commit 8957a49 into master Jun 11, 2018
@bpasero bpasero deleted the joao/grid-descriptor-support branch June 11, 2018 09:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants