Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributed tslint-plugin still has to be specified in the tsconfig.json #50682

Closed
egamma opened this issue May 29, 2018 · 4 comments
Closed
Assignees
Labels
typescript Typescript support issues verified Verification succeeded
Milestone

Comments

@egamma
Copy link
Member

egamma commented May 29, 2018

  • install the vscode-ts-tslint extension from the market place. This extension contributes the tslint-language- service
  • rename vanilla.txt to vanilla.zip and expand it vanilla.txt
  • open the vanilla folder

The tslint-language-service plugin is loaded and you will see warnings from tslint.
image

No remove the plugin definition from the tsconfig.json.

{
    "compilerOptions": {
        // "plugins": [
        //     {
        //         "name": "tslint-language-service"
        //     }
        // ],
        "module": "commonjs",
        "target": "es6",
        "allowJs": true,
        "noImplicitAny": false,
        "sourceMap": false
    }
}

Now the plugin is no longer loaded. My understanding is that contributed TS server plugins are now automatically loaded.

@egamma egamma added the typescript Typescript support issues label May 29, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented May 29, 2018

Are you using the workspace version of TypeScript?

@egamma
Copy link
Member Author

egamma commented May 30, 2018

No, this workspace is not using the workspace version. The workspace doesn´t have a workspace version of TypeScript.

Interestingly the lit-hmtl language server plugin is loaded and activated without any configuration in the tsconfig.json.

The source of the extension can be found here https://github.com/Microsoft/vscode-ts-tslint, but the VSIX had to be patched manually due to node-module dependencies see https://github.com/Microsoft/vscode-ts-tslint/blob/master/Notes.md.

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 1, 2018

Small bug in contribution, should be:

 "typescriptServerPlugins": [
            {
                "name": "tslint-language-service"
            }
        ]

I've pushed a fix. I'll also add a schema for this contribution point.

@mjbvz mjbvz closed this as completed Jun 1, 2018
@mjbvz mjbvz added this to the May 2018 milestone Jun 1, 2018
@egamma
Copy link
Member Author

egamma commented Jun 1, 2018

@mjbvz thanks for catching this! I´ve published a new version of the extension.

@egamma egamma added the verified Verification succeeded label Jun 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript Typescript support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants