workbench.action.focusNthEditorGroup commands should split right from the current editor group in some cases

[Tyriar]

VS Code version: Code - Insiders 1.24.0-insider (41a7c49, 2018-05-29T06:09:34.618Z)
OS version: Windows_NT x64 10.0.16299

---

#50458

Repro steps (Windows keybindings):

1. Open VS Code, close all editors
2. ctrl+2
3. alt+shift+o
4. ctrl+1
5. ctrl+3

I expect ctrl+3 to split right on the top editor since it's focused.

Expected:

Actual:

[bpasero]

@Tyriar I am not sure I would agree, I tried to maintain previous behaviour: Cmd+1 would focus the first view column, Cmd+2 the second and Cmd+3 the third. Now imagine you have a layout where 2 groups are opened side by side and you focus the first and press Cmd+3. With your model, a new group would open in the center and as such Cmd+2 would now go to the right group and Cmd+3 to the center group?

[Tyriar]

How about this then: if the nth group does not exist, cmd+n will open the nth group in the direction of workbench.editor.openSideBySideDirection, if the current orientation of the splitview does not match workbench.editor.openSideBySideDirection it will create a new grouping in that direction.

That should retain the current behavior and also behave more intuitive imo, as opposed to just create all new groups at the bottom-right.

[bpasero]

Let's leave this up for more feedback from others. I think the scenario from #50718 (comment) is an interesting one to support.

[vscodebot]

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!