Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing search text from the Extension search box results in Cannot read property 'reasonId' of undefined #50884

Closed
eamodio opened this issue May 31, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented May 31, 2018

Issue Type: Bug

  1. Open the Extensions view
  2. Type some text and then clear (delete) the text
  3. 🐛 A notification pops up saying Cannot read property 'reasonId' of undefined
notificationsAlerts.ts:40 TypeError: Cannot read property 'reasonId' of undefined
    at file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:4962:452
    at Array.map (native)
    at file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:4962:399
    at Object.g [as _notify] (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:149:807)
    at Object.enter (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:153:85)
    at n.Class.derive._oncancel._run (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:154:896)
    at n.Class.derive._oncancel._completed (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:154:337)
    at l (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:157:855)
    at n.Class.derive.join.r.forEach.j.then.o.(anonymous function) (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:158:45)
    at Object.g [as _notify] (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:149:807)
    at Object.enter (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:153:85)
    at n.Class.derive._oncancel._run (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:154:896)
    at n.Class.derive._oncancel._completed (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:154:337)
    at l (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:157:855)
    at n.Class.derive.join.r.forEach.j.then.o.(anonymous function) (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:158:45)
    at Object.g [as _notify] (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:149:807)
    at Object.enter (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:153:592)
    at n.Class.derive._oncancel._run (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:154:896)
    at n.Class.derive._oncancel._error (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:154:413)
    at file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:196:912
    at file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:286:300
    at C:\Program Files\Microsoft VS Code Insiders\resources\app\node_modules.asar\graceful-fs\polyfills.js:284:29
    at FSReqWrap.oncomplete (original-fs.js:114:15)

VS Code version: Code - Insiders 1.24.0-insider (0853749, 2018-05-31T05:17:57.180Z)
OS version: Windows_NT x64 10.0.17677

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 31.93GB (13.33GB free)
Process Argv C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe C:\Users\Eric\code\vscode-gitlens
Screen Reader no
VM 0%
@vscodebot vscodebot bot added the insiders label May 31, 2018
@vscodebot
Copy link

vscodebot bot commented May 31, 2018

@eamodio
Copy link
Contributor Author

eamodio commented May 31, 2018

None of those are duplicates

@octref octref added extensions Issues concerning extensions and removed insiders labels May 31, 2018
@ramya-rao-a
Copy link
Contributor

Thanks for reporting!
This is fixed with 015ec83

ramya-rao-a added a commit that referenced this issue May 31, 2018
@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label May 31, 2018
@ramya-rao-a ramya-rao-a added this to the May 2018 milestone May 31, 2018
@isidorn isidorn added the verified Verification succeeded label Jun 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants