-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lorem*2 only give one line of lorem #52345
Comments
I can recreate this.
VSCode 1.24.1// Windows 10 x64 |
PRs are welcome to fix this bug. The fix would be to the the upstream module called |
One way around this is setting this in your vscode user settings: "emmet.syntaxProfiles": {
"html":{
"inline_break": 1
}
} |
Fix microsoft/vscode#52345 There's a logic determining if a node should have be formatted. It uses inlineBreak, which is the option inline_break with default value of 3. In short, an emmet*2 couldn't generate 2 lines since the number of lines was less than 3.
@TheDancingCode Thanks, that gave me a hint to fix this issue! |
@ramya-rao-a, could you please review microsoft/vscode-emmet-helper#26? |
Thanks for figuring that out @TheDancingCode! @dyong0 I wouldnt change the default for
When trying out lorem in https://docs.emmet.io/, I noticed that But the new emmet modules dont do this and so end up becoming an inline element and forced to follow the How do you suggest we tackle this? |
Surrounding |
I've logged emmetio/expand-abbreviation#23 as an upstream issue with emmet and marking this issue as out of scope. Once there is a solution from upstream, we can use the same in VS Code |
This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider. If you wonder what we are up to, please see our roadmap and issue reporting guidelines. Thanks for your understanding and happy coding! |
\closedWith dc5a3da |
Verifier: Ensure that running |
Steps to Reproduce:
Result is expected to be 2 lines of lorem. but instead there is just one line with <number>*2 words.
Works fine with lorem*3
Does this issue occur when all extensions are disabled?: Yes
The text was updated successfully, but these errors were encountered: