Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Custom Title/Menubar on Windows/Linux #52854

Closed
3 tasks done
sbatten opened this issue Jun 26, 2018 · 4 comments
Closed
3 tasks done

Test: Custom Title/Menubar on Windows/Linux #52854

sbatten opened this issue Jun 26, 2018 · 4 comments

Comments

@sbatten
Copy link
Member

sbatten commented Jun 26, 2018

Test for #29024

Complexity: 4

Summary
On Windows and Linux, users can now opt in to use the custom titlebar that has been available on macOS for some time. With this change, we have implemented a new HTML-based menubar that is more accessible than the Electron version as well as just looks nicer. In order to match the new menubar, menus throughout the workbench are now using the same menu widget.

Test

  1. First, set window.titleBarStyle to custom and restart Code.
  2. Use the new titlebar and window controls.
  3. Use the new menubar.
  4. Try out menus throughout the workbench.

Things to verify

  • Do the window controls work as expected?
  • Can you navigate the menubar with a keyboard?
  • Can you navigate the menubar with the mouse?
  • Does the menubar honor settings like window.enableMenuBarMnemonics and window.menuBarVisibility?
  • Accessibility with screen readers
  • Do the actions in the menubar as well as menus throughout the workbench actually work?

See existing issues here for dupes Menu and Accessibility

@sbatten sbatten added this to the June 2018 milestone Jun 26, 2018
This was referenced Jun 26, 2018
@chpxu
Copy link

chpxu commented Jun 26, 2018

I'm not sure which issue to put this in, but I found that in each menu, there is a black box which surrounds part of the option, making it look weird, here is a screenshot, you can see the outline in the little box I made around it
menubug

EDIT: Happens on the first option, and carries on when using arrow keys to select; also appears on the menu that appears after clicking the little gear icon

@bpasero
Copy link
Member

bpasero commented Jun 26, 2018

@beastdestroyer that sounds like #52911

@chpxu
Copy link

chpxu commented Jun 26, 2018

@bpasero Yup, indeed it is, apologies for the trouble, if any!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants