Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu: Why is the custom title bar enabled on Linux? #53001

Closed
Tyriar opened this issue Jun 26, 2018 · 2 comments
Closed

Menu: Why is the custom title bar enabled on Linux? #53001

Tyriar opened this issue Jun 26, 2018 · 2 comments
Assignees
Labels
linux Issues with VS Code on Linux titlebar VS Code main title bar issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2018

#52854

It looks super weird having a Windows-style title bar with the Windows menu font. Also I don't think we get any real accessibility benefits out of it as alt shortcuts work fine using the native title bar and we don't support screen readers on Linux.

@Tyriar Tyriar added linux Issues with VS Code on Linux under-discussion Issue is under discussion for relevance, priority, approach titlebar VS Code main title bar issues labels Jun 26, 2018
@Tyriar Tyriar changed the title Why is the custom title bar enabled on Linux? Menu: Why is the custom title bar enabled on Linux? Jun 26, 2018
@bpasero
Copy link
Member

bpasero commented Jun 26, 2018

@Tyriar a lot of people ask for a themable title area though, so I think there is still people that would want this. I agree though that the styling should be Linux specific and not Windows if possible.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 26, 2018

a lot of people ask for a themable title area though

I always saw those issues as better integrating with the native, like #49967 and #36667

I agree though that the styling should be Linux specific and not Windows if possible.

I'm not sure this is possible though as it's so customizable and different on every distro, the best you could get is based on the default Ubuntu theme.


I'll close this off as I guess it can't hurt much to have it there. The only problem I can think of is if someone wants to share their settings file across platforms and have different values for each.

@Tyriar Tyriar closed this as completed Jun 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linux Issues with VS Code on Linux titlebar VS Code main title bar issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants