Localized descriptions for settings dont show up in Extensions view

[ramya-rao-a]

For all our built-in extensions, we have the package-nls.json such that extension and settings descriptions are localized.
These localized strings dont appear in the extensions view:

The above shows a weird mixture of English and localized strings.

[sandy081]

@dbaeumer @joaomoreno

We read the package.json and package.nls.json and apply translations. If I see into the our built in extension folders of the product, there is package.nls.json file only in english.

Is this due to the change in the way we do translations now?

[dbaeumer]

Yes, these are now in the language pack. I adopted the contribution points when we read the extensions but not the extension editor. @joaomoreno can you point me to where the code is. Then I can have a look. The code that does the adoption for the package.json when scanning for extensions is here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/extensions/node/extensionPoints.ts#L144

[sandy081]

@dbaeumer Its here

[dbaeumer]

Fixed in referenced PR:

[sandy081]

@dbaeumer As you said, we never showed localised manifest in extension editor.

@ramya-rao-a

We can do this only for installed extensions and for non installed ones we do not not have translations. So this will cause some extensions to show translated strings and some does not. We have to be careful with this as users can complain and we cannot support until Market place team supports it or we find a different approach.

Hence my suggestion is to put more thinking about how to support translations for market place extensions and release it completely.

[wraith13]

Because it happens like the image below, I am very sad.

[wraith13]

I strongly hope to be able to localize README as well.

( I tryed "readme" : "%readme%" in package.json, but it did not work too. )

[ruslan-bikkinin]

Hi guys, since we added localization to our extensions Contributions page has become completely unreadable:

From my point of view it's not a feature request, but bug. I hope you'll do something about it.

[dbaeumer]

@sandy081 this also happens with our extensions. We can either use the cached version of the package.json for extension management which has the translation replaced your run it through the same transformer.

[sandy081]

Is it possible to apply translations dynamically on package.json files so that this can be fixed for all (installed and ones from market place)?

[dbaeumer]

Yes, the code sits here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/extensions/node/extensionPoints.ts#L107

But it might need some refactoring to be used in other contexts. From where would you call this?

[sandy081]

I think it will be in renderer while displaying

[dbaeumer]

That should be fine.

[pikadun]

Hi: @sandy081

I see here read package.nls.json.
Whether to use package.nls.<locale>.json instead?

Or is it possible to dynamically generate files when the extension is activated?

[sandy081]

Translation files are in language pack extensions. So the right solution is based on the locale read the translations from the pack that support this locale/

[Colengms]

Note that this behavior extends to previewing of extensions in the marketplace.

[GitMensch]

@Colengms said (15 days ago)

Note that this behavior extends to previewing of extensions in the marketplace.

which brings us back to what @sandy081 said 28 months ago:

We can do this only for installed extensions and for non installed ones we do not not have translations. So this will cause some extensions to show translated strings and some does not. We have to be careful with this as users can complain and we cannot support until Market place team supports it or we find a different approach.

So yes, obviously:

• users do complain, count me in this list
• users count that as bug, not as a feature-request
• the only place where this seems to be solvable for the marketplace is to get the market place support translations

What is the state of this? Backlog4ever? This issue has no one assigned from the marketplace team, has it?

[vscodenpa]

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

[tylor-metrics]

So sad that this is not getting fixed.
Is there a work-around, other than simply not localizing the extension?

[tylor-metrics]

lol 16 bugs closed in relation this one. .... "won't fix"