Debt - remove WinJS.Promise#cancel usage

[jrieken]

There are still a few WinJS.Promise#cancel usages and we should remove those. Find detail about how and why here #53526.

Todos for WinJS.Promise#cancel

• src/vs/base/test/common/async.test.ts @jrieken @joaomoreno
• src/vs/workbench/api/electron-browser/mainThreadSearch.ts @roblourens -> Use CancellationToken for search #57957
• src/vs/base/common/async.ts @jrieken @joaomoreno
• vs/workbench/api/node/extHostSearch.ts @roblourens
• (skipped those that we still have for a short period, e.g. in IPC)

Todos for WinJS.Promise creation with a non-empty cancel-callback

• src/vs/base/node/request.ts#67 -> CancellationToken for request logic #57955
• src/vs/base/common/async.ts#63
• src/vs/base/common/async.ts#191
• src/vs/base/common/async.ts#361
• src/vs/base/test/common/async.test.ts#94
• src/vs/base/test/common/async.test.ts#116
• src/vs/base/test/common/utils.ts#21 @jrieken
• src/vs/editor/standalone/browser/colorizer.ts#58 @alexandrudima
• src/vs/workbench/api/node/extHostSearch.fileIndex.ts#436 @roblourens
• src/vs/workbench/api/node/extHostSearch.fileIndex.ts#482
• src/vs/workbench/api/node/extHostSearch.fileIndex.ts#483
• src/vs/workbench/api/node/extHostSearch.fileIndex.ts#506
• src/vs/workbench/api/node/extHostSearch.fileIndex.ts#551
• src/vs/workbench/api/node/extHostSearch.fileIndex.ts#632
• src/vs/workbench/api/node/extHostSearch.fileIndex.ts#667
• src/vs/workbench/api/node/extHostSearch.fileIndex.ts#694
• src/vs/workbench/api/node/extHostSearch.ts#86 -> Use CancellationToken for search #57957
• src/vs/workbench/api/node/extHostSearch.ts#311 -> Use CancellationToken for search #57957
• src/vs/platform/request/electron-browser/requestService.ts#25 -> CancellationToken for request logic #57955
• src/vs/base/parts/tree/browser/treeModel.ts#89 @joaomoreno
• src/vs/base/parts/ipc/node/ipc.ts#313
• src/vs/workbench/services/extensions/node/lazyPromise.ts#40

[jrieken]

The goal is to finish this in September but it won't hurt to remove one or two usages in August

[bpasero]

I opened #56656 for the zip.ts case.

@jrieken this is not just TPromise#cancel() but also every new TPromise(..., onCancel), did you account for that as well? There may be more clients of that pattern.

[jrieken]

every new TPromise(..., onCancel), did you account for that as well?

Theory is that we can delete that once no more calls to cancel exist

[jrieken]

@bpasero Assigned you back for getResults(searchValue: string): TPromise<IModel<any>> on which search cancellation depends.

[bpasero]

There is now a CancellationToken that is passed on to the quick open handler which will be cancelled when quick open closes or changes. I need support for this token in the following places before I can remove the cancel() method in openAnythingHandler:

• searchService.search(...) @roblourens
• support.provideWorkspaceSymbols(...) @jrieken

[roblourens]

I still cancel promises normally across the IPC right? I'd left some of my references which are close to the IPC (but I'll remove it from the SearchService API)

[jrieken]

@bpasero you are the last user of asWinJsPromise: https://github.com/Microsoft/vscode/blob/2b960fb0ff8c0473c7b0d46b0d50a33aab8c947e/src/vs/workbench/parts/quickopen/browser/gotoSymbolHandler.ts#L487. it need support in that quick open handler

[sandy081]

@joaomoreno Added you for extensionEditor. Cancellation here needs to be travelled till gallery/request service.

[sandy081]

@joaomoreno One ✅ less for you.. I took care of handling cancellation token in Extension editor. Thanks to @jrieken's PR of adding cancellation token to request API.

FYI I did not add cancellation tokens for all APIs in Gallery service, I only added to those which are needed and can be added to others on need. Feedback is welcome on the changes.

[jrieken]

We are now free of asWinJSPromise and free of wireCancellationToken! Thanks everyone so far.

@bpasero re #56137 (comment). I left a todo here which is about supporting cancelation in quick open handlers.

[joaomoreno]

72484fd removes WinJS.Promise dependency from IPC. Its dependency is solely on Thenable objects. 🎆

[roblourens]

🎉 DONE 🎉

[jrieken]

We are done! There is no more WinJS.Promise#cancel. Thanks to everyone helping with this!

[joaomoreno]