-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use webpack for all big extensions #57680
Comments
How about the debug extensions? It's more complicated because I'd have to webpack the vscode-chrome-debug-core npm module but node-debug2 is much bigger than search-rg. chrome-debug was webpacked a long time ago but was too hard to maintain, I think it's easier now. |
sure, everything that reduces the bundles size is good |
microsoft/ApplicationInsights-node.js#426 is about making the AppInsights module (which most extension depend on via vscode-extension-telemetry) webpack friendly. Having that will reduce the bundle size drastically. |
@jrieken how should extensions living outside of VS Code source tree "inherit from the shared config"? |
Yeah, that's the question. The config can be copied but more tweaks will be required because some build trickery that we do in VS Code won't be available to you. |
Ok. I will look into that in October... Moved my first attempts to a aweinand/webpack branch |
We can ship less and gain more. This is a simple sample that enables webpack for extensions:
extension.webpack.config.js
. All configs should inherit from the shared config, get in touch with me if something doesn't work.extension.webpack.config.js
npx webpack --config extensions/<your-extension>/extension.webpack.config.js
.vscodeignoe
file, exclude theout
folder and config-fileyarn run gulp vscode-darwin
etc before pushingExtensions that should be webpack'ed:
The text was updated successfully, but these errors were encountered: