Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output channel for telemetry.log file #58536

Closed
ramya-rao-a opened this issue Sep 12, 2018 · 5 comments
Closed

Output channel for telemetry.log file #58536

ramya-rao-a opened this issue Sep 12, 2018 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality telemetry Telemetry system issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@ramya-rao-a
Copy link
Contributor

As per work done for #54001, we now have a telemetry.log file in the logs folder that tracks all telemetry events being logged in VS Code.

This file has been accessible using the Open Log File or Open Log Folder commands.

Since all the other "log" files also have a corresponding output channel, the telemetry.log file is an odd person out.

Also, due to recent refactoring, the file is no longer accessible via the Open Log File command in 1.28 insiders.

This issue is to have an output channel for the telemetry.log file to make it more inline with the other log files.

cc @sandy081

@ramya-rao-a ramya-rao-a added engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality telemetry Telemetry system issues and removed engineering VS Code - Build / issue tracking / etc. labels Sep 12, 2018
@ramya-rao-a ramya-rao-a self-assigned this Sep 12, 2018
@ramya-rao-a ramya-rao-a added this to the September 2018 milestone Sep 12, 2018
@sandy081
Copy link
Member

@ramya-rao-a Just to be clear, telemetry file was not accessible even before (refactoring). Because Open Log File... command always used to open Log Viewer which uses Output channels.

@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented Sep 13, 2018

@sandy081 Not true. The telemetry file is indeed accessible in 1.27.1

  • Set log level to trace
  • Open a few files
  • Use the command Open Log File.. and select Telemetry from the quick pick.

The file will open in VS Code and will have the events corresponding to the file opens

Unless, there were more refactorings after 1.27.1 and before 0f84693

@sandy081
Copy link
Member

@ramya-rao-a I take back my comment. Yes you are right, it was showing the telemetry log before in the log viewer.

I can enhance the log viewer to show log files which are not registered in output channel. Personally I think it will be much consistent if telemetry log is also part of the output channel just like others.

@ramya-rao-a
Copy link
Contributor Author

If we do add an output channel for telemetry log, would it be possible to do that only when the user changes the log level to trace? Because otherwise, that channel will always be empty.

@sandy081
Copy link
Member

May be register and de-register it ?

@ramya-rao-a ramya-rao-a added the verification-needed Verification of issue is requested label Sep 24, 2018
@jrieken jrieken added the verified Verification succeeded label Sep 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality telemetry Telemetry system issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants