Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log telemetry events into separate log file and the output channels for logs #54001

Closed
ramya-rao-a opened this issue Jul 11, 2018 · 4 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality telemetry Telemetry system issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jul 11, 2018

At present, there is no way for a user to know what telemetry events are being logged in VS Code other than searching the code base for telemetryService.publicLog. Event after doing so, its never clear what data is exactly being sent. In order to be transparent, we need to have a dedicated place where the user can see all the telemetry events being logged along with the data being sent.

The output channels for the logs (when in trace mode) from various processes (main, shared, renderer) can also benefit from the inclusion of the telemetry events (with common data removed to reduce noise) as this will help the development/debugging process.

@ramya-rao-a ramya-rao-a added feature-request Request for new features or functionality telemetry Telemetry system issues labels Jul 11, 2018
@ramya-rao-a ramya-rao-a added this to the July 2018 milestone Jul 11, 2018
@ramya-rao-a ramya-rao-a self-assigned this Jul 11, 2018
@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented Jul 11, 2018

Here is my proposal:

When the log level is changed to trace or VS Code is started in the cli with --verbose option

  • The telemetry events for the main, renderer, shared and issue reporter processes will appear in the respective log files with reduced content (event name + data without noise from common data). Use Developer: Open Log File to open the log files.
  • The above will also appear in corresponding output channels Log (Main), Log (Window) and Log (Shared).
  • All telemetry events (other than the ones from cli process) with all data is logged to a new dedicated file telemetry.log. This file will live in the same place as other log files and can be opened using the Open Log File command.
  • The telemetry events from the cli process will be included in the cli.log file (this is the existing file that has logs from the cli process) when started using the --verbose flag

Note: This does not include telemetry events sent from extensions.

@ramya-rao-a
Copy link
Contributor Author

Re-opening to investigate logging telemetry events from extensions that use our vscode-extension-telemetry module to send telemetry

@jens1o
Copy link
Contributor

jens1o commented Jul 21, 2018

Finally. :)

@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented Jul 30, 2018

With microsoft/vscode-extension-telemetry#21, the built-in extensions will also log the telemetry events to log files in the same folder as rest of the log files when VS Code is started in --verbose mode.

#55398 tracks the feature request to enable the same when VS Code is started normally and the log level then changed to trace

@sbatten sbatten added the verification-needed Verification of issue is requested label Aug 1, 2018
@roblourens roblourens added the verified Verification succeeded label Aug 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality telemetry Telemetry system issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants