Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile extension host when needed #60332

Closed
jrieken opened this issue Oct 9, 2018 · 3 comments
Closed

Profile extension host when needed #60332

jrieken opened this issue Oct 9, 2018 · 3 comments
Assignees
@jrieken
Labels
extension-host Extension host issues feature-request Request for new features or functionality on-testplan release-notes Release notes issues
Milestone
November 2018

Comments

@jrieken
Copy link
Member

jrieken commented Oct 9, 2018

We finally have all pieces to automatically start profiling the extension host when it goes dark. This is a flow I would like to have:

  • detect that the extension host is unresponsive (by waiting for the ack-messages)
  • attach the profiler and profile for a bit
  • associate time slices from the profile to extensions (just like the Running Extension View does it after profiling)
  • show a message to file a bug against the heaviest hitters...
@jrieken jrieken self-assigned this Oct 9, 2018
@jrieken jrieken added feature-request Request for new features or functionality extension-host Extension host issues labels Oct 9, 2018
@jrieken
Copy link
Member Author

jrieken commented Oct 9, 2018

cc @egamma

@jrieken jrieken added this to the November 2018 milestone Nov 8, 2018
jrieken added a commit that referenced this issue Nov 12, 2018
@jrieken
first cut of auto extension profiler, #60332
118c31e
jrieken added a commit that referenced this issue Nov 12, 2018
@jrieken
tweak telemetry #60332
6040b14
@kieferrm kieferrm mentioned this issue Nov 12, 2018
Closed
45 tasks
jrieken added a commit that referenced this issue Nov 13, 2018
@jrieken
fail silent when not able to connect, #60332
138e66a
jrieken added a commit that referenced this issue Nov 13, 2018
@jrieken
remove logic to show an exthost-unresponsive message to the user, #60332
c5718c6
jrieken added a commit that referenced this issue Nov 13, 2018
@jrieken
stop profiling as soon as extension host is responsive again, #60332
2a89180
@jrieken
Copy link
Member Author

jrieken commented Nov 13, 2018

With today's insiders build we start profiling the extension host as soon as it is found to be unresponsive. Finding are currently send as telemetry and logged down as message:

screenshot 2018-11-13 at 15 12 24

jrieken added a commit that referenced this issue Nov 13, 2018
@jrieken
send duration as micro seconds, #60332
989b7ae
@alexdima alexdima removed their assignment Nov 14, 2018
jrieken added a commit that referenced this issue Nov 16, 2018
@jrieken
use random port #60332
66461d3
@jrieken jrieken mentioned this issue Nov 16, 2018
Closed
jrieken added a commit that referenced this issue Nov 22, 2018
@jrieken
write profile to disk and log filename, #60332
1fae869
jrieken added a commit that referenced this issue Nov 26, 2018
@jrieken
show blocking extension in editor, #60332
91fb4ec
jrieken added a commit that referenced this issue Nov 26, 2018
@jrieken
fix warning message, #60332
0bbbf26
jrieken added a commit that referenced this issue Nov 26, 2018
@jrieken
tweak interfaces, #60332
b381d64
jrieken added a commit that referenced this issue Nov 26, 2018
@jrieken
check for unresponsive profile when reporting an extension issue, #60332
b6569f3
jrieken added a commit that referenced this issue Nov 26, 2018
@jrieken
show a silent notification for extension frezing for 5secs and more #…
2d74edf 
…60332
jrieken added a commit that referenced this issue Nov 26, 2018
@jrieken
simpler API use, #60332
dfa22cc
@jrieken
Copy link
Member Author

jrieken commented Nov 27, 2018 •
edited
Loading

Closing, we now have the log file writing, telemetry, and a silent* user-facing notification when an extension is really greedy.

screenshot 2018-11-27 at 12 30 58

*a silent notification shows the bell in the status bar but doesn't reveal itself into your face

jrieken added a commit that referenced this issue Nov 27, 2018
@jrieken
know how effective the silent notification is, #60332
489dbed
@jrieken jrieken closed this as completed Nov 27, 2018
jrieken added a commit that referenced this issue Nov 27, 2018
@jrieken
only set nodeCachedData-prop when having a dir, #60332
2c531e2
@jrieken jrieken mentioned this issue Dec 3, 2018
Closed
2 tasks
@mjbvz mjbvz mentioned this issue Dec 4, 2018
Closed
@jrieken jrieken added the release-notes Release notes issues label Dec 7, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
extension-host Extension host issues feature-request Request for new features or functionality on-testplan release-notes Release notes issues
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
2 participants
@jrieken @alexdima