Making vscode.executeCommand('vscode.previewHtml', ...) a compile error

[mjbvz]

Part of #62630

Discourage people from writing the most simple form of the vscode.previewHtml command by making:

vscode.executeCommand('vscode.previewHtml')

A compile error. Obviously this compile time check won't block sneaky code like:

const command = 'vscode.previewHtml'
vscode.executeCommand(command)

or:

vscode.executeCommand('vscode' + '.' + 'previewHtml')

We've already added a runtime warning for development extensions that will catch the above examples and will upgrade this into a user facing warning after a few months

[isidorn]

I do not get an error if I use
vscode.commands.executeCommand('vscode.previewHtml');

Am i supposed to use some special version of ts? Or should I be good out of the box?

[mjbvz]

Yeah this does not work well using an overload since most cases aren't caught. We have to revert the proper fix, 96ddd4f, because the conditional types broke our build (and would have broken anyone using TS 2.8 or older to target newer VS Code versions).

I'm just going to revert the overload too and mark this as not worth the effort

[isidorn]

@mjbvz ok. Removing verification-needed than