Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on terminal TypedArray-based buffer by default #63688

Closed
Tyriar opened this issue Nov 23, 2018 · 6 comments · Fixed by #64243
Closed

Turn on terminal TypedArray-based buffer by default #63688

Tyriar opened this issue Nov 23, 2018 · 6 comments · Fixed by #64243
Assignees
Labels
debt Code quality issues terminal Integrated terminal issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 23, 2018

"terminal.integrated.experimentalBufferImpl": "TypedArray"

Testing should focus on resizing the terminal as well as inputting emoji, CJK and "high plane chars" (those with a char code above 65535).

@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues labels Nov 23, 2018
@Tyriar Tyriar added this to the December 2018 milestone Nov 23, 2018
@Tyriar Tyriar self-assigned this Nov 23, 2018
@nojvek
Copy link
Contributor

nojvek commented Nov 24, 2018

Been playing with this option. I have to say the perf is quite amazing. I'm very impressed that the vscode terminal is actually faster than than both iTerm and built-in Mac OSX terminal.

That's what I love about vscode. It's attention to perf. Thank you!

@Tyriar
Copy link
Member Author

Tyriar commented Nov 26, 2018

@nojvek glad to hear you've been testing it out! Much more in the works 😃

This particular one was pretty much all @jerch 💪 xtermjs/xterm.js#791

@jerch
Copy link

jerch commented Nov 26, 2018

Thx @nojvek! We still have a few more perf gems to come with the next releases, stay tuned 😺

And thx for testing, we need every helping hand to cover the edge cases, esp. for those bigger changes.

@nojvek
Copy link
Contributor

nojvek commented Dec 7, 2018

Btw I used vscode terminal extensively to test v2 of matrix-rain.

You can try it at npm install -g matrix-rain; matrix-rain

Vscode terminal is the fastest out of iTerm and macOS Terminal app.

So looking forward to a super fast terminal (hopefully standalone someday).

@Tyriar
Copy link
Member Author

Tyriar commented Dec 7, 2018

@nojvek nice! xtermjs/xterm.js#1790 will make it even better when that eventually goes in

@Tyriar
Copy link
Member Author

Tyriar commented Jan 2, 2019

I removed the JsArray completely as TypedArray is very stable at this point.

Tyriar added a commit that referenced this issue Jan 2, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 21, 2019
@Tyriar Tyriar added debt Code quality issues and removed feature-request Request for new features or functionality labels Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues terminal Integrated terminal issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants