-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on terminal TypedArray-based buffer by default #63688
Comments
Been playing with this option. I have to say the perf is quite amazing. I'm very impressed that the vscode terminal is actually faster than than both iTerm and built-in Mac OSX terminal. That's what I love about vscode. It's attention to perf. Thank you! |
@nojvek glad to hear you've been testing it out! Much more in the works 😃 This particular one was pretty much all @jerch 💪 xtermjs/xterm.js#791 |
Thx @nojvek! We still have a few more perf gems to come with the next releases, stay tuned 😺 And thx for testing, we need every helping hand to cover the edge cases, esp. for those bigger changes. |
Btw I used vscode terminal extensively to test v2 of matrix-rain. You can try it at Vscode terminal is the fastest out of iTerm and macOS Terminal app. So looking forward to a super fast terminal (hopefully standalone someday). |
@nojvek nice! xtermjs/xterm.js#1790 will make it even better when that eventually goes in |
I removed the JsArray completely as TypedArray is very stable at this point. |
Testing should focus on resizing the terminal as well as inputting emoji, CJK and "high plane chars" (those with a char code above 65535).
The text was updated successfully, but these errors were encountered: