Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification that an extension took too long requires some polish #64353

Closed
isidorn opened this issue Dec 4, 2018 · 5 comments
Closed

Notification that an extension took too long requires some polish #64353

isidorn opened this issue Dec 4, 2018 · 5 comments
Assignees
@jrieken
Labels
extension-host Extension host issues under-discussion Issue is under discussion for relevance, priority, approach
Milestone
November 2018

Comments

@isidorn
Copy link
Contributor

isidorn commented Dec 4, 2018

Refs: #64222

I suggest to:

  1. Use the warning notifcation, not an info. Since it is a warning after all, not something positive
  2. I would try not to use the word task so users do not think corallate this with our Task framework. I suggest the following text

Extension 'nov-ext' took a very long time for computation and it has prevented other extensions from running.

screenshot 2018-12-04 at 16 12 00
@isidorn isidorn changed the title Notification that an extension took to long requires some polish Notification that an extension took too long requires some polish Dec 4, 2018
@jrieken jrieken added this to the November 2018 milestone Dec 5, 2018
@jrieken jrieken added extension-host Extension host issues under-discussion Issue is under discussion for relevance, priority, approach labels Dec 5, 2018
@jrieken
Copy link
Member

jrieken commented Dec 5, 2018

Use the warning notifcation, not an info.

Not sure about that - it's nothing bad, it's a computer after all and I don't wanna scare people into filling thousands of issues...

@jrieken
Copy link
Member

jrieken commented Dec 5, 2018

I would try not to use the word task so users

That makes sense

@isidorn
Copy link
Contributor Author

isidorn commented Dec 5, 2018

But it is also nothing good. I mean it is not an error, it is a simple warning.
Not sure how scary a warning icon is.

fyi @bpasero @misolori

jrieken added a commit that referenced this issue Dec 5, 2018
@jrieken
avoid confusion and use 'operation' instead of 'task', #64353
fdafac3
jrieken added a commit that referenced this issue Dec 5, 2018
@jrieken
show a warning instead of info, #64353
5c2aba6
@jrieken
Copy link
Member

jrieken commented Dec 5, 2018

well, a warning it then is...

screenshot 2018-12-05 at 14 28 45

@jrieken jrieken closed this as completed Dec 5, 2018
@isidorn
Copy link
Contributor Author

isidorn commented Dec 5, 2018

Looks better! Thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
extension-host Extension host issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
2 participants
@jrieken @isidorn