Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll bar to integrated terminal #6602

Closed
bpasero opened this issue May 21, 2016 · 16 comments
Closed

Add scroll bar to integrated terminal #6602

bpasero opened this issue May 21, 2016 · 16 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented May 21, 2016

On Mac I am not getting scrollbars when the content overflows.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label May 21, 2016
@Tyriar
Copy link
Member

Tyriar commented May 21, 2016

Known issue, not sure scrollbars are going to happen unless we fork term.js.

@Tyriar Tyriar added the terminal Integrated terminal issues label May 21, 2016
@Tyriar
Copy link
Member

Tyriar commented May 23, 2016

Forking term.js would also be necessary if we wanted to do any improvements to the UX inside the terminal. For example improving the selection experience (related to this), adding links or something to terminal for tighter integration with editor (#1037), making the cursor blink without breaking selection, etc.

@bastienJS
Copy link

I use the integrated terminal only for doing "ng build" and getting an error message about what failed to build. But I am never able to read the cause of the failed build because I can not scroll up. Not every error is in the error windows. Sometimes error appear only at build process.

Thus if you want to justify the existance of the integrated terminal it really needs scrollbars or I have to the CMD.

@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2016

@bastienJS you should still be able to scroll using the mouse wheel and ctrl+shift+arrows/page up/page down.

@Tyriar Tyriar changed the title Terminal: I am not getting scrollbars for scrolling? Add scroll bar to integrated terminal Jul 5, 2016
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jul 5, 2016
@Tyriar
Copy link
Member

Tyriar commented Jul 5, 2016

This needs to be tackled upstream first at xtermjs/xterm.js#77

@gertcuykens
Copy link

OSX 0.11.6 / vscode 1.3.1

  • fn + up down arrow doesn't work in terminal it gives a ~ character instead.
  • scroll speed per line results into a much faster and choppy scroll then in a normal vscode editor window, try to make sure scroll speed of all different windows are the same in vscode if technically possible.

@gertcuykens
Copy link

gertcuykens commented Aug 4, 2016

Plan B: Disable mouse scroll completely to prevent accidental scrolling and introduce a new button that opens a new editor tab with a copy of the console buffer output. As a bonus you can then keep that output and use it as a copy paste clip board.
image

@Tyriar
Copy link
Member

Tyriar commented Aug 4, 2016

@gertcuykens the WIP PR is out for the scroll bar xtermjs/xterm.js#218, it supports mouse wheel events that scroll by pixel, line and page. It's very smooth based on my testing so far.

@pierznj
Copy link

pierznj commented Aug 5, 2016

Scrollbar for the integrated terminal would be awesome.

@Tyriar Tyriar removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Aug 8, 2016
Tyriar added a commit that referenced this issue Aug 8, 2016
@Tyriar Tyriar closed this as completed in 4cbec65 Aug 9, 2016
@bpasero bpasero added the verified Verification succeeded label Sep 1, 2016
@bpasero bpasero added this to the August 2016 milestone Sep 1, 2016
@emartinpi
Copy link

emartinpi commented Sep 9, 2016

I just updated Code to version 1.5 and the scrolling in integrated terminal doesn't work well.
When type a command that produces a content overflow, the scroll bar shows up and while that command is running, the scroll bar is there, visible. But when you kill the process the scroll bar vanish

VSCode Version:1.5
OS Version: OS X El Capitan 10.11.6

@Tyriar
Copy link
Member

Tyriar commented Sep 9, 2016

@emartinpi are you using oh-my-zsh? The scroll bar should be visible and working whenever application keypad mode is disabled.

@emartinpi
Copy link

@Tyriar yes, i'm using oh-my-zsh. Application keypad mode was enabled so I disabled it from terminal menu, reset VCode but nothing changed in integrated terminal, the same behavior keeps going

@Tyriar
Copy link
Member

Tyriar commented Sep 9, 2016

@emartinpi I suspect this is the root cause of the issue xtermjs/xterm.js#151

@jcarter
Copy link

jcarter commented Sep 9, 2016

@emartinpi this worked for me - #7817 (comment)

@emartinpi
Copy link

Thanks @jcarter It worked for me as well, but I suppose this workaround may break some key bindings...
@Tyriar Will there be a fix for this issue?

@Tyriar
Copy link
Member

Tyriar commented Sep 12, 2016

@emartinpi I was hoping someone from the community would be able to chip in on #7817 / xtermjs/xterm.js#151, I don't use oh-my-zsh personally and won't have time to look at it any time soon.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants