Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting for fontSize and lineHeight to the integrated terminal #6728

Closed
alexdima opened this issue May 24, 2016 · 0 comments · Fixed by #6998
Closed

Add setting for fontSize and lineHeight to the integrated terminal #6728

alexdima opened this issue May 24, 2016 · 0 comments · Fixed by #6998
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label
Milestone
June 2016

Comments

@alexdima
Copy link
Member

Testing #6654

When changing the fontFamily, the default font size and/or line height don't necessarily look good anymore.

When adding the option to change the fontFamily it is a good practice to allow changing the fontSize and the lineHeight as well,.
@Tyriar Tyriar added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label labels May 24, 2016
@Tyriar Tyriar added this to the June 2016 milestone May 24, 2016
@kisstkondoros kisstkondoros mentioned this issue May 28, 2016
Merged
kisstkondoros added a commit to kisstkondoros/vscode that referenced this issue Jun 2, 2016
@kisstkondoros
Add setting for fontSize and lineHeight to the integrated terminal
46ab627 
resolves microsoft#6728
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
June 2016
Development

Successfully merging a pull request may close this issue.

Add setting for fontSize and lineHeight to the integrated terminal kisstkondoros/vscode
2 participants
@Tyriar @alexdima