Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schemas to customData samples #67608

Closed
kieferrm opened this issue Jan 31, 2019 · 2 comments · May be fixed by GarfieldZHU/vscode#2
Closed

Add schemas to customData samples #67608

kieferrm opened this issue Jan 31, 2019 · 2 comments · May be fixed by GarfieldZHU/vscode#2
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded

Comments

@kieferrm
Copy link
Member

Issue Type: Bug

Testing #67306.

Since we have JSON schemas, we should make it easier for people to use them. We should add them to the samples and also tell people how to use them in the docs.

I added the following to my workspace settings:

    "json.schemas": [
        {
            "fileMatch": [
                "/custom-data/html.json"
            ],
            "url": "https://raw.githubusercontent.com/Microsoft/vscode-html-languageservice/master/docs/customData.schema.json"
        },
        {
            "fileMatch": [
                "/custom-data/css.json"
            ],
            "url": "https://raw.githubusercontent.com/Microsoft/vscode-css-languageservice/master/docs/customData.schema.json"
        }
    ]

VS Code version: Code - Insiders 1.31.0-insider (9606490, 2019-01-30T15:15:08.172Z)
OS version: Darwin x64 18.0.0

octref added a commit to octref/simple-customdata that referenced this issue Jan 31, 2019
octref added a commit to octref/svg-data that referenced this issue Jan 31, 2019
@octref octref added this to the December/January 2019 milestone Jan 31, 2019
@octref octref added css-less-scss Issues and items concerning CSS,Less,SCSS styling bug Issue identified by VS Code Team member as probable bug labels Jan 31, 2019
@octref
Copy link
Contributor

octref commented Jan 31, 2019

Good point on using the URL to check against latest version of the schema. I updated both samples to use this setting and updated docs to suggest using json.schemas.

@aeschli aeschli added the verified Verification succeeded label Feb 1, 2019
@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2019

See #67742 on how to improve that even more so that users don't need to add an association anymore.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Projects
None yet
4 participants
@octref @kieferrm @aeschli and others