Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve custom data schemas #67747

Closed
aeschli opened this issue Feb 1, 2019 · 6 comments
Closed

Improve custom data schemas #67747

aeschli opened this issue Feb 1, 2019 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling html HTML support issues verified Verification succeeded

Comments

@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2019

html:

css:

  • version can be const: 1.
  • simplify oneOf:[{enum with `"enum": ["standard", "experimental",...]``
  • add pattern and patternErrorMessage to verify browsers
  • use $ref to have avoid multiple definitions for definitions for browsers and status
@vscodebot vscodebot bot added the json JSON support issues label Feb 1, 2019
@octref
Copy link
Contributor

octref commented Feb 1, 2019

enum doesn't show suggestion for me, that's why I changed to oneOf. Others make sense, I'll update them.

@octref octref added this to the On Deck milestone Feb 1, 2019
@octref octref added bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling html HTML support issues and removed json JSON support issues labels Feb 1, 2019
@aeschli
Copy link
Contributor Author

aeschli commented Feb 1, 2019

enum shows suggestions, we use it everywhere, there must have been some other issue.

@octref
Copy link
Contributor

octref commented Feb 1, 2019

anyOf on Attributes: After removing it, we don't get any suggestion for the array:

image

@octref
Copy link
Contributor

octref commented Feb 1, 2019

I see, that's when I should use defaultSnippets...

octref added a commit to microsoft/vscode-css-languageservice that referenced this issue Feb 1, 2019
octref added a commit to microsoft/vscode-html-languageservice that referenced this issue Feb 1, 2019
octref added a commit to microsoft/vscode-html-languageservice that referenced this issue Feb 1, 2019
octref added a commit to microsoft/vscode-css-languageservice that referenced this issue Feb 1, 2019
octref added a commit to microsoft/vscode-css-languageservice that referenced this issue Feb 1, 2019
octref added a commit to microsoft/vscode-css-languageservice that referenced this issue Feb 1, 2019
octref added a commit to microsoft/vscode-html-languageservice that referenced this issue Feb 1, 2019
@octref
Copy link
Contributor

octref commented Feb 1, 2019

Verifier:

@octref
Copy link
Contributor

octref commented Feb 1, 2019

can there be both values and valueSet?

Yes. Attribute value completion gets values from both.

@mjbvz mjbvz added the verified Verification succeeded label Feb 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling html HTML support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants