Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict null check 'quickOpenWidget.ts' #67774

Closed
mjbvz opened this issue Feb 1, 2019 · 3 comments
Closed

Strict null check 'quickOpenWidget.ts' #67774

mjbvz opened this issue Feb 1, 2019 · 3 comments
Assignees
Labels
engineering VS Code - Build / issue tracking / etc. under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Feb 1, 2019

Part of #60565

Tracks updating ./vs/base/parts/quickopen/browser/quickOpenWidget.ts to have strict null checking. This should be the last file in vs/base that needs strict null checking

Steps

  1. Add ./vs/base/parts/quickopen/browser/quickOpenWidget.ts to the include section of src/tsconfig.strictNullChecks.json
  2. Run yarn strict-null-check -- --watch
  3. Fix strict null check compiler errors
  4. Verify normal build still works
@mjbvz mjbvz added the engineering VS Code - Build / issue tracking / etc. label Feb 1, 2019
@mjbvz mjbvz added this to the February 2019 milestone Feb 1, 2019
@bpasero
Copy link
Member

bpasero commented Feb 4, 2019

I think it makes little sense to invest more into this widget which is going to be replaced by @chrmarti implementation ideally (see #29096).

@chrmarti is there something that would prevent us from using your widget for quick open in general? E.g. something missing? We also need to keep in mind that the standalone editor is using this widget, so your solution would have to live in base as well.

@bpasero bpasero added the under-discussion Issue is under discussion for relevance, priority, approach label Feb 4, 2019
@chrmarti
Copy link
Contributor

chrmarti commented Feb 4, 2019

@bpasero The feature gaps should be small by now. Moving quick open over will still be a major refactoring. If it is not much work, we can do the strict null checks to keep that effort unblocked.

@bpasero
Copy link
Member

bpasero commented Feb 4, 2019

I pushed a half-baked strict null solution knowing that this widget has reached EOL.

@bpasero bpasero closed this as completed Feb 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc. under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants