-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict null check 'quickOpenWidget.ts' #67774
Comments
I think it makes little sense to invest more into this widget which is going to be replaced by @chrmarti implementation ideally (see #29096). @chrmarti is there something that would prevent us from using your widget for quick open in general? E.g. something missing? We also need to keep in mind that the standalone editor is using this widget, so your solution would have to live in base as well. |
@bpasero The feature gaps should be small by now. Moving quick open over will still be a major refactoring. If it is not much work, we can do the strict null checks to keep that effort unblocked. |
I pushed a half-baked strict null solution knowing that this widget has reached EOL. |
Part of #60565
Tracks updating
./vs/base/parts/quickopen/browser/quickOpenWidget.ts
to have strict null checking. This should be the last file invs/base
that needs strict null checkingSteps
./vs/base/parts/quickopen/browser/quickOpenWidget.ts
to theinclude
section ofsrc/tsconfig.strictNullChecks.json
yarn strict-null-check -- --watch
The text was updated successfully, but these errors were encountered: