Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can recursively peek definitions #6786

Closed
joaomoreno opened this issue May 24, 2016 · 4 comments
Closed

I can recursively peek definitions #6786

joaomoreno opened this issue May 24, 2016 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented May 24, 2016

Testing #6662

Recursively peeking definitions ends in this state:

image

After the first peek, the trees in the following peeks are always empty.

Is this expected?

@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label May 24, 2016
@jrieken jrieken added this to the May 2016 milestone May 24, 2016
@jrieken
Copy link
Member

jrieken commented May 24, 2016

Is this expected?

It's cool but it should not be like that ;-)

@stevencl
Copy link
Member

It would be great to be able to cascade peek definition (and references). Visual Studio supports cascading peek and shows a breadcrumb above the peek window to indicate how deep you have gone:
peek

@kieferrm
Copy link
Member

Recursive peeking is useful in a lot of situations. However, I'd expect it to reuse the existing window and on ESC or close box to take down only the most topmost one.

@jrieken
Copy link
Member

jrieken commented May 25, 2016

That's in line with @stevencl suggestion. I have created a separate issue for this: #6857

@jrieken jrieken closed this as completed May 25, 2016
@jrieken jrieken assigned joaomoreno and unassigned jrieken May 26, 2016
@joaomoreno joaomoreno added the verified Verification succeeded label May 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants