Electron 3.0.x: Pale/desaturated colors #68001

atomiks · 2019-02-06T19:51:45Z

⚠️ bpasero: ⚠️

This will be fixed in Electron 4 when via @poiru electron/electron#15898. Please expect Electron 4 to be out in 2-3 months.

If you cannot wait until then, consider to use our exploration builds that already ship with Electron 4:

We are building exploration builds (you might need to update from within once to get latest) that use a much newer version of our UI framework (Electron version 4.0.x). I wonder if this issue reproduces with one of these builds, could you try? Download:

macOS: Download
Linux: Download
Windows: Download

Original Issue:

VSCode Version: 1.31.0
OS Version: macOS 10.14.2

Same as atom/atom#17356

The new color profile makes the editor appear desaturated compared to the previous version. Is there an option to use the previous sRGB profile again? (Atom's checkbox doesn't actually work)

Does this issue occur when all extensions are disabled?: Yes

vscodebot · 2019-02-06T19:52:11Z

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

Add a setting to support RGB color profile chosen by OS (#65816)

jhpratt · 2019-02-06T22:43:30Z

Seconding this on Ubuntu 18.04.

To be clear, this isn't a subtle change. The new colors are actually more vibrant, which is absolutely not what I want. I have a theme with pastel colors, and this change renders some text nearly illegible.

kika · 2019-02-07T00:16:52Z

Before update (now taken from Android Studio where I have my color scheme and where I copied the colors from):

After update:

In particular, some shades of green are now indistinguishable.

But before the update, I copied the colors from Android Studio using screen color picker, and now I can obtain the same colors by copying hex values. Which means that at least now VSCode uses the same color matching mechanism.

I'm on MacOS 10.13.6 and use a wide-gamut monitor.

sam3d · 2019-02-07T00:30:41Z

I'm also seeing this on MacOS 10.14.2 on a 2017 Macbook Pro monitor using the Dark Molokai Theme:

Before update (`v1.30.2`)

After update (`v1.31.0`)

It's a kind of subtle change but it's definitely noticeable. Like @jhpratt I have a vibrant colour theme for a reason, I need the high contrast for usability.

Edit: I've simply downgraded to v1.30.2 and will keep it there until this is fixed.

tannergaucher · 2019-02-07T03:52:10Z

Also getting this after upgrade on MacOS 10.14.2 and my 2017 Macbook Pro with Atom One Dark theme. Colors are considerably less saturated.

bpasero · 2019-02-07T07:25:59Z

This will be fixed in Electron 4 via @poiru electron/electron#15898. Please expect Electron 4 to be released in stable in 2-3 months.

If you cannot wait until then, consider to use our exploration builds that already ship with Electron 4:

We are building exploration builds that use a much newer version of our UI framework (Electron version 4.0.x). I wonder if this issue reproduces with one of these builds, could you try? Download:

macOS: Download
Linux: Download
Windows: Download

atomiks · 2019-02-07T07:46:41Z

The darwin exploration build still has the desaturated colors. I'm also noticing some color artifacts in the editor background on 1.31 on the right side in the form "tiles" around where the line selection is, which appear to be fixed in the darwin build. Does there need to be a checkbox to use the old color profile?

For anyone wanting the vibrant colors back, on macOS, you can set the whole OS to use sRGB in System Prefs > Displays > Colour:

This has the side effect of making everything in the OS appear overly vibrant/saturated, something that I only like in my editor for the bright syntax highlighting...

bpasero · 2019-02-07T07:51:59Z

@poiru is there anything else required than:

app.commandLine.appendSwitch('disable-features', 'ColorCorrectRendering');

poiru · 2019-02-07T07:52:45Z

@bpasero You need to switch to app.commandLine.appendSwitch('disable-color-correct-rendering').

bpasero · 2019-02-07T13:03:13Z

I pushed this change to the exploration build. Can someone verify?

ablakey · 2019-02-07T14:47:24Z

Not 100% sure I'm dealing with the same issue, but it looks unchanged. Downloaded Exploration build 1 minute ago.

Version: 1.31.0-exploration
Commit: 37818ac

(Is the link in the first post still correct for Linux? Where can I find a more generic landing page for Exploration build?)

Just wanted to share that this is a blocking issue for me. Call me a broken human but this faded colour is more distracting to my job than a fire alarm going off. I eagerly hope we can help get this fixed in any build. Otherwise I'll seek info on how to revert to 1.30 for the next 2-3 months. Thanks for your help!

bpasero · 2019-02-07T15:34:27Z

@ablakey should mention, those links are old and you need to update once to get latest!

ablakey · 2019-02-07T15:41:17Z

Derp. Of course!

You might have to take my word for it. It is noticeably better to my eyes. The background is distinctly darker.

ablakey · 2019-02-08T15:19:04Z

So I did something unconscionably awful.

I didn't want to use a different version of code because I didn't want to migrate all of my settings, extensions, etc. over.

In /usr/share/code/resources/app/out/main.js I replaced:

app.commandLine.appendSwitch("disable-features", "ColorCorrectRendering");

with:

app.commandLine.appendSwitch('force-color-profile', 'srgb');

(via sed or your favourite editor with sudo privileges)

This probably relies heavily on my computer's environment settings, the monitor's profile, and whatnot. So I anticipate this is not a globally useful solution.

This modifies built code in /usr/share/ which is preeeeetty awful. But it works. I expect it will get clobbered when vscode gets updated next. I can't understate how "wrong" this is. But it solved my problem very easily and may help others.

poiru · 2019-02-08T15:41:18Z

Just for the record, --force-color-profile=srgb does not work on macOS.

Zeex · 2019-02-09T21:14:34Z

@ablakey's fix worked for me too on Ubuntu 18.10

dhowden · 2019-02-25T11:31:03Z

Just tried the exploration build for macOS and this does not appeared to be fixed there. Is there a more up-to-date exploration build we should be trying?

I have tried build 37818ac3597b4afda264b05226b0b77fb8e85f41.

ablakey · 2019-03-18T13:27:38Z

Are my eyes going bad or does this appear to be fixed in the latest release? Either that, or this issue isn't replicated in Bionic, which I switched to recently.

dhowden · 2019-03-18T21:58:32Z

I've been switching back and forth between the recent versions (back to 1.30.2). I still see the same issue.

Which version are you trying?

atomiks · 2019-04-02T08:40:36Z

I can confirm it's fixed in the macOS download link version (after updating it) and the colors are vibrant again 🌈. When does that version go stable? I've been staying on 1.30.2

nchengyeeshen · 2019-04-09T01:39:52Z

I'm on Fedora 29, VSCode 1.33.0 and colours are still weird unless I force the colour profile to become sRGB.

Another temporary fix I've found is to override the .desktop file by copying it to ~/.local/share/applications and then adding --force-color-profile=srgb at the Exec line in code.desktop, like so
Exec=/usr/share/code/code --force-color-profile=srgb --unity-launch %F.

You might have to restart your desktop environment for this to take effect.

jhpratt · 2019-04-11T04:05:47Z

This will be fixed in Electron 4 via @poiru electron/electron#15898. Please expect Electron 4 to be released in stable in 2-3 months.

@bpasero Any updates, or an ETA on when Electron 4 will ship beneath Code? Every single update forces me to pull this issue back up to find the necessary file and flag I need to switch. At the very least, putting in an option to toggle it would be great.

jhpratt · 2019-04-18T04:50:57Z

@bpasero

I'm interpreting a lack of response (given your activeness on GitHub) as "we have no timeframe", which is a shame, really. Tons of people are affected by this, and there's no effort to change it.

Upgrading to Electron 4 is the suggested solution, but this has been deferred past the April release (due to come out May 6), per #71830. Your estimated timeframe was 2-3 months, and the release on May 6 is the long end of that. I (along with others) would very much appreciate an updated estimate.

At the absolute least, adding a dropdown in the settings to toggle the rendering would solve the issue temporarily.

atomiks · 2019-04-18T05:04:11Z

It seems like the only thing blocking the upgrade is #69301. No response since February from Electron team :\

bpasero · 2019-04-18T06:39:27Z

@jhpratt I have just triggered a new Exploration build with latest changes. Have you considered staying on that version until we did the move?

Download:

macOS: Download
Linux: Download
Windows: Download

bpasero · 2019-04-18T06:41:40Z

As for the setting: since this is something that needs to be set very early on on startup, we do not have access to our settings file yet. Since startup performance is critical to us, we (so far) have stayed away from blocking the startup to read the settings file.

dhowden · 2019-05-22T07:54:24Z

@bpasero Has the latest exploration build broken this again? This was working fine, seems to have stopped working for me today. I updated to macOS 10.14.5 last night, so that might have caused the problem (hope not, less likely to be fixable!).

Edit: I'm running Version 1.35.0-exploration (1.35.0-exploration) (1bdebe7e66e42d73b62c578b46fdc9a3e84c99d5)

bpasero · 2019-05-22T11:41:05Z

@deepak1556 maybe knows

bpasero · 2019-06-11T16:14:31Z

Are people (@atomiks) still seeing this with latest VSCode insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

Those have been updated to Electron 4. Just curious.

atomiks · 2019-06-12T01:06:30Z

Nope, the desaturated colors and artifact problem are both gone in the latest builds with Electron 4

ablakey · 2019-06-12T05:04:50Z

I cannot reproduce the issue on latest insiders.

…

On Tue, Jun 11, 2019, 12:16 PM Benjamin Pasero ***@***.***> wrote: Are people still seeing this with latest VSCode insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/ Those have been updated to Electron 4. Just curious. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#68001?email_source=notifications&email_token=ACE2T6FDQKYI6FKUYJMVEZTPZ7FXNA5CNFSM4GUX5ZL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXNVROA#issuecomment-500914360>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACE2T6EKYJNOWSVV475V43TPZ7FXNANCNFSM4GUX5ZLQ> .

bpasero · 2019-07-01T06:26:45Z

We will ship with Electron 4 with our upcoming release 1.36 this week. As such I am closing this issue. To benefit from the update already today, consider to use our insiders version: https://code.visualstudio.com/insiders/

dhowden · 2019-07-16T02:49:01Z

Running the latest insiders, looks like the color saturation issue has returned... Reporting here as it is related, apologies if this should be a new issue!

Version: 1.37.0-insider
Commit: 894056d
Date: 2019-07-15T05:24:02.940Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.6.0

vscodebot bot added the new release label Feb 6, 2019

kieferrm assigned bpasero Feb 6, 2019

bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron electron-3.0.x-update labels Feb 7, 2019

bpasero changed the title ~~Pale/desaturated colors in 1.31.0~~ Electron 3.0.x: Pale/desaturated colors Feb 7, 2019

bpasero mentioned this issue Feb 10, 2019

The colors are not consistent across the editor. Some colors are faded #68341

Closed

vscodebot bot removed the new release label Feb 10, 2019

jhpratt mentioned this issue Apr 18, 2019

Iteration Plan for April 2019 #71830

Closed

9 tasks

This was referenced Jun 3, 2019

Issue with the editor background color atomiks/moonlight-vscode-theme#5

Closed

Artifacts in editor background on macOS #75171

Closed

bpasero closed this as completed Jul 1, 2019

bpasero added this to the June 2019 milestone Jul 1, 2019

vscodebot bot locked and limited conversation to collaborators Aug 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Electron 3.0.x: Pale/desaturated colors #68001

Electron 3.0.x: Pale/desaturated colors #68001

atomiks commented Feb 6, 2019 •

edited by bpasero

Loading

vscodebot bot commented Feb 6, 2019

jhpratt commented Feb 6, 2019 •

edited

Loading

kika commented Feb 7, 2019 •

edited

Loading

sam3d commented Feb 7, 2019 •

edited

Loading

tannergaucher commented Feb 7, 2019

bpasero commented Feb 7, 2019 •

edited

Loading

atomiks commented Feb 7, 2019

bpasero commented Feb 7, 2019 •

edited

Loading

poiru commented Feb 7, 2019

bpasero commented Feb 7, 2019 •

edited

Loading

ablakey commented Feb 7, 2019

bpasero commented Feb 7, 2019

ablakey commented Feb 7, 2019

ablakey commented Feb 8, 2019 •

edited

Loading

poiru commented Feb 8, 2019 •

edited

Loading

Zeex commented Feb 9, 2019

dhowden commented Feb 25, 2019 •

edited

Loading

ablakey commented Mar 18, 2019 •

edited

Loading

dhowden commented Mar 18, 2019

atomiks commented Apr 2, 2019

nchengyeeshen commented Apr 9, 2019

jhpratt commented Apr 11, 2019

jhpratt commented Apr 18, 2019

atomiks commented Apr 18, 2019

bpasero commented Apr 18, 2019

bpasero commented Apr 18, 2019

dhowden commented May 22, 2019 •

edited

Loading

bpasero commented May 22, 2019

bpasero commented Jun 11, 2019 •

edited

Loading

atomiks commented Jun 12, 2019

ablakey commented Jun 12, 2019 via email

bpasero commented Jul 1, 2019

dhowden commented Jul 16, 2019

Electron 3.0.x: Pale/desaturated colors #68001

Electron 3.0.x: Pale/desaturated colors #68001

Comments

atomiks commented Feb 6, 2019 • edited by bpasero Loading

vscodebot bot commented Feb 6, 2019

jhpratt commented Feb 6, 2019 • edited Loading

kika commented Feb 7, 2019 • edited Loading

sam3d commented Feb 7, 2019 • edited Loading

Before update (v1.30.2)

After update (v1.31.0)

tannergaucher commented Feb 7, 2019

bpasero commented Feb 7, 2019 • edited Loading

atomiks commented Feb 7, 2019

bpasero commented Feb 7, 2019 • edited Loading

poiru commented Feb 7, 2019

bpasero commented Feb 7, 2019 • edited Loading

ablakey commented Feb 7, 2019

bpasero commented Feb 7, 2019

ablakey commented Feb 7, 2019

ablakey commented Feb 8, 2019 • edited Loading

poiru commented Feb 8, 2019 • edited Loading

Zeex commented Feb 9, 2019

dhowden commented Feb 25, 2019 • edited Loading

ablakey commented Mar 18, 2019 • edited Loading

dhowden commented Mar 18, 2019

atomiks commented Apr 2, 2019

nchengyeeshen commented Apr 9, 2019

jhpratt commented Apr 11, 2019

jhpratt commented Apr 18, 2019

atomiks commented Apr 18, 2019

bpasero commented Apr 18, 2019

bpasero commented Apr 18, 2019

dhowden commented May 22, 2019 • edited Loading

bpasero commented May 22, 2019

bpasero commented Jun 11, 2019 • edited Loading

atomiks commented Jun 12, 2019

ablakey commented Jun 12, 2019 via email

bpasero commented Jul 1, 2019

dhowden commented Jul 16, 2019

atomiks commented Feb 6, 2019 •

edited by bpasero

Loading

jhpratt commented Feb 6, 2019 •

edited

Loading

kika commented Feb 7, 2019 •

edited

Loading

sam3d commented Feb 7, 2019 •

edited

Loading

Before update (`v1.30.2`)

After update (`v1.31.0`)

bpasero commented Feb 7, 2019 •

edited

Loading

bpasero commented Feb 7, 2019 •

edited

Loading

bpasero commented Feb 7, 2019 •

edited

Loading

ablakey commented Feb 8, 2019 •

edited

Loading

poiru commented Feb 8, 2019 •

edited

Loading

dhowden commented Feb 25, 2019 •

edited

Loading

ablakey commented Mar 18, 2019 •

edited

Loading

dhowden commented May 22, 2019 •

edited

Loading

bpasero commented Jun 11, 2019 •

edited

Loading