Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing launch config without a 'type' attribute to 'vscode.startDebug' does not return an error #6809

Closed
weinand opened this issue May 24, 2016 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented May 24, 2016

testing #6248:

  • VSCode Version: 1.1.0 alpha
  • OS Version: OS X 10

Steps to Reproduce:

Observe:
no error is reported.

'type' is a mandatory attribute that should result in error if missing.
But it should be possible to omit attribute 'name' without error.

@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels May 24, 2016
@isidorn isidorn added this to the May 2016 milestone May 24, 2016
@isidorn
Copy link
Contributor

isidorn commented May 25, 2016

Currently the command returns the errors, after consulting with Joh it is the extensions responsibility to handle this error in any way the extension writer wants. Closing as designed. More details:

screen shot 2016-05-25 at 11 39 38

@isidorn isidorn closed this as completed May 25, 2016
@weinand
Copy link
Contributor Author

weinand commented May 25, 2016

@isidorn What error is returned if attribute 'type' is missing?

isidorn added a commit that referenced this issue May 25, 2016
@isidorn
Copy link
Contributor

isidorn commented May 25, 2016

With the commit I just pushed it returns a proper error message 😊

screen shot 2016-05-25 at 11 53 32

Maybe we should tune the error message such that it does not refer to launch.json

@isidorn isidorn assigned weinand and unassigned isidorn May 25, 2016
@weinand weinand added the verified Verification succeeded label May 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants