Extension Host holds onto file locks causing builds to fail

[moizgh]

Issue Type: Bug

using the rush tool to build, Extension host keeps locks on files and rush build fails consistently.

VS Code version: Code 1.31.1 (1b8e830, 2019-02-12T02:21:36.727Z)
OS version: Windows_NT ia32 10.0.14393

System Info

Item	Value
CPUs	Intel(R) Xeon(R) CPU E5-1680 v4 @ 3.40GHz (16 x 3392)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Memory (System)	63.90GB (55.94GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (7)

Extension	Author (truncated)	Version
npm-intellisense	chr	1.3.0
gitlens	eam	9.5.0
tslint	eg2	1.0.43
vscode-npm-script	eg2	0.3.5
prettier-vscode	esb	1.8.1
git-tree-compare	let	1.5.0
code-spell-checker	str	1.6.10

[alexdima]

@moizgh AFAIK, the extension host does not hold any locks by itself. Could you figure out which files are locked? (it would help us try to identify which extension holds locks)

[moizgh]

This is an example of the issue we are hitting consistently. ``ERROR: EPERM: operation not permitted, lstat 'C:\Users\chrlo\office-shared-comments-ui\packages\canvas-simulator\node_modules'Often this is caused by a file lock from a process such as your text editor, command prompt, or "gulp serve"`` From: Alexandru Dima <notifications@github.com> Sent: Wednesday, February 13, 2019 2:30 AM To: Microsoft/vscode <vscode@noreply.github.com> Cc: Moiz Ghadiyali <moizgh@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [Microsoft/vscode] Extension Host holds onto file locks causing builds to fail (#68576) @moizgh<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmoizgh&data=02%7C01%7Cmoizgh%40microsoft.com%7C3a076541d5db42aa0b1608d691850e3e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636856397993561405&sdata=8wP6agKeLHz9ICHlnh1G2pNIKHJtYU8doqjPBq1dNOE%3D&reserved=0> AFAIK, the extension host does not hold any locks by itself. Could you figure out which files are locked? (it would help us try to identify which extension holds locks) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvscode%2Fissues%2F68576%23issuecomment-463089306&data=02%7C01%7Cmoizgh%40microsoft.com%7C3a076541d5db42aa0b1608d691850e3e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636856397993561405&sdata=ZUBgUgRy6afY4TPMXzHaRsXY%2B2XPI%2FEzEJjCHSQvnSw%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYvHC1Kc4BXIAXWbuk1cHdmEy3-ovyblks5vM771gaJpZM4a4Q6S&data=02%7C01%7Cmoizgh%40microsoft.com%7C3a076541d5db42aa0b1608d691850e3e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636856397993571402&sdata=5Q2CAptGd6wCP0A4ba9BM106JiDZwgktP4%2BZn5nvV9c%3D&reserved=0>.

[alexdima]

@moizgh When this happens, can you please use ProcessExplorer or similar software to identify the process id which is holding on to the file?

e.g. https://social.technet.microsoft.com/Forums/windowsserver/en-US/504017c7-1a92-415e-b12c-03d44145e1db/how-to-find-which-process-locked-the-log-file

Once you have identified the process id, can you please include here the command line arguments for it (so we can find out which one of our processes it is)?

[moizgh]

[cid:image001.jpg@01D4C482.A6E560F0] From: Alexandru Dima <notifications@github.com> Sent: Thursday, February 14, 2019 4:17 AM To: Microsoft/vscode <vscode@noreply.github.com> Cc: Moiz Ghadiyali <moizgh@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [Microsoft/vscode] Extension Host holds onto file locks causing builds to fail (#68576) @moizgh<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmoizgh&data=02%7C01%7Cmoizgh%40microsoft.com%7C756076098bc4414da2df08d6925d1c11%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636857325931762895&sdata=Izg%2Fve2L%2FP1anQPotGeWqxHy%2BJ%2FRETvk0pBHf0Wfqpg%3D&reserved=0> When this happens, can you please use ProcessExplorer or similar software to identify the process id which is holding on to the file? Once you have identified the process id, can you please include here the command line arguments for it (so we can find out which one of our processes it is)? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvscode%2Fissues%2F68576%23issuecomment-463551767&data=02%7C01%7Cmoizgh%40microsoft.com%7C756076098bc4414da2df08d6925d1c11%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636857325931762895&sdata=Pqihmo6zg9wthaw70jHCiklkonIHLTbziMVpJap9nhw%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYvHC-_AD21KJqyE5xtTzZb31ehwwhgTks5vNSlvgaJpZM4a4Q6S&data=02%7C01%7Cmoizgh%40microsoft.com%7C756076098bc4414da2df08d6925d1c11%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636857325931772899&sdata=6JhuUH4SxTYC0Bhk0N5iz2HXwvgLYybFUFO3ie%2BNS2k%3D&reserved=0>.

[falsandtru]

I've seen a similar problem since 1.29.x or 1.30.x.

Error: EPERM: operation not permitted, stat ...

This error is caused by even another standalone terminal when vscode launched by code --disable-extensions is running . And this will be resolved by closing vscode. So vscode has almost definitely affected permissions. I'm unable to reproduce this problem on ubuntu so probably this problem can be seen only on windows.

[falsandtru]

Repro:

1. clone https://github.com/falsandtru/spica on Windows 10
2. run npm i
3. launch vscode
4. launch a standalone terminal
5. run gulp dist; this will be succeeded.
6. run gulp dist again; this will be failed by a permission error.
7. shutdown vscode
8. run gulp dist; this will be succeeded.

[alexdima]

@moizgh Can you please use the github UI at #68576 . All your email messages look funny and attachments are not making it through.

---

@falsandtru Can you please use ProcessExplorer or similar software to identify the process id which is holding on to the file?

e.g. https://social.technet.microsoft.com/Forums/windowsserver/en-US/504017c7-1a92-415e-b12c-03d44145e1db/how-to-find-which-process-locked-the-log-file

Once you have identified the process id, can you please include here the command line arguments for it (so we can find out which one of our processes it is)?

[falsandtru]

@alexandrudima I confirmed Code.exe is the only holder of the directory handler using ProcessExplorer. But I don't know what the command line arguments mean.

[falsandtru]

@alexandrudima Ah probably you mean this, right?

 ...\spica\node_modules\typescript\lib\tsserver.js --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName ...\AppData\Local\Temp\vscode-typescript\tscancellation-98807ed02d080a987f69.tmp* --locale en --noGetErrOnBackgroundUpdate

[moizgh]

[alexdima]

Thank you for following through, from the command line arguments, that looks to be the TypeScript server process that is locking up those files/folders.

[mjbvz]

Tracked upstream by microsoft/TypeScript#29856 and similar to microsoft/TypeScript#29407