vscode.workspace.findFiles now splits comma-separated glob patterns

[roblourens]

Use this code in an extension, run the command

'use strict';

import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext) {

    let disposable = vscode.commands.registerCommand('extension.helloWorld', () => {
        const workspace = vscode.workspace.workspaceFolders![0];
        if (workspace) {
            vscode.workspace.findFiles('package.json, tsconfig.json').then(results => {
                console.log('results: ', results);
            });
        }
    });

    context.subscriptions.push(disposable);
}

• In 1.31, it returns no results because findFiles takes a single glob pattern
• In 1.32, it returns results because the include and exclude patterns for findFiles are split on the comma

[roblourens]

This is a candidate because it would be an API change. If we want to support multiple glob patterns we should use an array like we discussed in #38545. Parsing a comma-delimited string in this API feels wrong.